# Code Review: ProGenFix

**URL:** <https://www.ruby-forum.com/t/code-review-progenfix/169680>\
**Category:** IronRuby\
**Created:** [June 6, 2009, 10:02pm UTC](https://www.ruby-forum.com/t/code-review-progenfix/169680 "2009-06-06T22:02:43Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 6, 2009, 10:02pm UTC](https://www.ruby-forum.com/t/code-review-progenfix/169680/1 "2009-06-06T22:02:43Z")

</div>

tfpt review “/shelveset:ProGenFix;REDMOND\tomat”

DLR, Python, Ruby.

Fixes Ruby calls to protected generic methods.  
Adds CompilerHelpers.IsProtected() as an alias for IsFamily ||  
IsFamilyOrAssembly.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 6, 2009, 11:17pm UTC](https://www.ruby-forum.com/t/code-review-progenfix/169680/2 "2009-06-06T23:17:39Z")

</div>

Changes look good overall. I’m not sure that Type.IsProtected() is an  
intuitive name; maybe Type.IsNested() would be clearer?

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 7, 2009, 1:02am UTC](https://www.ruby-forum.com/t/code-review-progenfix/169680/3 "2009-06-07T01:02:28Z")

</div>

You mean IsNestedProteced()? “Nested” feels superfluous since only  
nested types could be protected.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 7, 2009, 1:26am UTC](https://www.ruby-forum.com/t/code-review-progenfix/169680/4 "2009-06-07T01:26:28Z")

</div>

Ah, I see. Still, something strikes me as odd about the name, but I  
don’t feel strongly about it.