# Code Review: NoStaticSites4

**URL:** <https://www.ruby-forum.com/t/code-review-nostaticsites4/154248>\
**Category:** IronRuby\
**Created:** [November 26, 2008, 6:30pm UTC](https://www.ruby-forum.com/t/code-review-nostaticsites4/154248 "2008-11-26T18:30:03Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 26, 2008, 6:30pm UTC](https://www.ruby-forum.com/t/code-review-nostaticsites4/154248/1 "2008-11-26T18:30:03Z")

</div>

tfpt review “/shelveset:NoStaticSites4;REDMOND\tomat”

Adds support for SiteLocalStorage to IronRuby binder. This allows us to  
store arbitrary data in dynamic site rules including other dynamic  
sites. Using this feature library methods that dynamically invoke other  
Ruby methods should now take as parameters all sites they’re using  
instead of calling to statically allocated sites. This will allows us to  
remove runtime checks from the rules and also decreases the degree of  
polymorphism for the sites (since static sites are used from many places  
with variety of targets they tend to be megamorphic).

This is first part of the change. Many static sites still remain to be  
removed. Some library methods (e.g. Range#step) are highly dynamic. Some  
method need refactoring to reduce the number of sites.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 26, 2008, 9:51pm UTC](https://www.ruby-forum.com/t/code-review-nostaticsites4/154248/2 "2008-11-26T21:51:29Z")

</div>

Looks good.