# Code Review: NoComplexCall

**URL:** <https://www.ruby-forum.com/t/code-review-nocomplexcall/154074>\
**Category:** IronRuby\
**Created:** [November 25, 2008, 3:37am UTC](https://www.ruby-forum.com/t/code-review-nocomplexcall/154074 "2008-11-25T03:37:13Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 25, 2008, 3:37am UTC](https://www.ruby-forum.com/t/code-review-nocomplexcall/154074/1 "2008-11-25T03:37:13Z")

</div>

tfpt review “/shelveset:NoComplexCall;REDMOND\tomat”

Outer DLR Change: Tweaks outer layer DynamicSiteHelpers to publish  
delegate type factory method (this class will hopefully go away as soon  
as LambdaExpression provides the same functionality).

Ruby changes: Removes ComplexCallHelper and other useless stuff from  
AstFactory 🙂

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 25, 2008, 4:16am UTC](https://www.ruby-forum.com/t/code-review-nocomplexcall/154074/2 "2008-11-25T04:16:27Z")

</div>

Two misspellings should be noted – the shelveset is actually named  
NoComplexCalls and RubyMethodInfo.PramsArrayDelegateType needs another  
“a”. 🙂

Looks good otherwise.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 25, 2008, 4:22am UTC](https://www.ruby-forum.com/t/code-review-nocomplexcall/154074/3 "2008-11-25T04:22:18Z")

</div>

Looks good!