# Code Review: netinterop1

**URL:** <https://www.ruby-forum.com/t/code-review-netinterop1/161375>\
**Category:** IronRuby\
**Created:** [February 26, 2009, 12:02am UTC](https://www.ruby-forum.com/t/code-review-netinterop1/161375 "2009-02-26T00:02:23Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 26, 2009, 12:02am UTC](https://www.ruby-forum.com/t/code-review-netinterop1/161375/1 "2009-02-26T00:02:23Z")

</div>

tfpt review “/shelveset:netinterop1;REDMOND\jdeville”  
Comment :  
Adds more netinterop tests related to methods.  
Adds these tests to snap.  
Reorganizes the ruby generictest folder  
Adds the command line tests to snap  
Adds tags for netinterop  
Modifies testsupport.cs (ClrAssembly) to make the Flag Value field  
public to match with other Flag classes, and to work better with Ruby  
testing.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 26, 2009, 2:12am UTC](https://www.ruby-forum.com/t/code-review-netinterop1/161375/2 "2009-02-26T02:12:27Z")

</div>

Do people prefer using “” or “/” as the directory separator in Ruby  
code? I prefer “/” since all existing Ruby code uses that, and Ruby on  
windows understands it as well. Plus you don’t have to play the  
escape-slash game when using double-quoted strings.

Also, some folks might be confused at the strange class/method names  
uses in these tests. They come from rowantest.\*.dll, which are full of  
test cases IronPython uses for .NET interop testing, so we are just  
reusing them. However, it’s only a temporary solution, as we’ll probably  
move to a C#-code-inline approach which Jim is going to get working  
shortly.

Regardless, I approve =)

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 26, 2009, 2:32am UTC](https://www.ruby-forum.com/t/code-review-netinterop1/161375/3 "2009-02-26T02:32:56Z")

</div>

Where are you talking about / vs ? I’ll change it. The \ in context.rb  
has to stay because it gets put directly into app.config during the  
transforms.

The odd class names (rowantest.\*.dll) are in the git repo at  
Merlin\Main\Test\ClrAssembly. It’s a naked csproj (no solution), but it  
should compile from VS. I might remove it after inline support is  
finished.

JD