# Code Review: MutableStringSqueeze

**URL:** <https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459>\
**Category:** IronRuby\
**Created:** [June 26, 2008, 12:56am UTC](https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459 "2008-06-26T00:56:22Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Dave\_Remy](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/9fc29f/32.png) [@Dave\_Remy](https://www.ruby-forum.com/u/Dave_Remy)\
**Post date:** [June 26, 2008, 12:56am UTC](https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459/1 "2008-06-26T00:56:22Z")

</div>

tfpt review “/shelveset:MutableStringSqueeze;REDMOND\dremy”  
Comment :  
Implement String.squeeze and String.squeeze!  
Passes RubySpec tests. Passes Unit tests.

---

<div class="post-metadata">

**Author:** ![Dave\_Remy](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/9fc29f/32.png) [@Dave\_Remy](https://www.ruby-forum.com/u/Dave_Remy)\
**Post date:** [June 26, 2008, 8:08pm UTC](https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459/2 "2008-06-26T20:08:00Z")

</div>

Looks good.

Tomas

---

<div class="post-metadata">

**Author:** ![Dave\_Remy](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/9fc29f/32.png) [@Dave\_Remy](https://www.ruby-forum.com/u/Dave_Remy)\
**Post date:** [June 26, 2008, 8:15pm UTC](https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459/3 "2008-06-26T20:15:39Z")

</div>

Should the comment:

“putters putt balls”.squeeze(“mz”) =\> “puters put balls”

be

“putters putt balls”.squeeze(“m-z”) =\> “puters put balls”

Robert.

---

<div class="post-metadata">

**Author:** ![Dave\_Remy](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/9fc29f/32.png) [@Dave\_Remy](https://www.ruby-forum.com/u/Dave_Remy)\
**Post date:** [June 26, 2008, 10:16pm UTC](https://www.ruby-forum.com/t/code-review-mutablestringsqueeze/141459/4 "2008-06-26T22:16:33Z")

</div>

Yes! Thanks!

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Robert Horvick  
Sent: Thursday, June 26, 2008 11:15 AM  
To: removed\_email\_address@domain.invalid  
Subject: Re: [Ironruby-core] Code Review: MutableStringSqueeze

Should the comment:

“putters putt balls”.squeeze(“mz”) =\> “puters put balls”

be

“putters putt balls”.squeeze(“m-z”) =\> “puters put balls”

Robert.  
On Wed, Jun 25, 2008 at 6:55 PM, Dave Remy  
\<removed\_email\_address@domain.invalid[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)\> wrote:  
tfpt review “/shelveset:MutableStringSqueeze;REDMOND\dremy”  
Comment :  
Implement String.squeeze and String.squeeze!  
Passes RubySpec tests. Passes Unit tests.