# Code Review: MoreSites4

**URL:** <https://www.ruby-forum.com/t/code-review-moresites4/155276>\
**Category:** IronRuby\
**Created:** [December 10, 2008, 3:21am UTC](https://www.ruby-forum.com/t/code-review-moresites4/155276 "2008-12-10T03:21:24Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 10, 2008, 3:21am UTC](https://www.ruby-forum.com/t/code-review-moresites4/155276/1 "2008-12-10T03:21:24Z")

</div>

tfpt review “/shelveset:MoreSites4;REDMOND\tomat”

DLR change:  
Inherits SiteLocalStorage from SiteLocalStorage class and enables  
any subclass of SiteLocalStorage to be created as a storage for data in  
a rule.

Ruby:  
Implements multiple SiteLocalStorage subclasses for the most frequent  
site storage types: CallSiteStorage, BinaryOpStorage, UnaryOpStorage,  
ConversionStorage.  
Implements ConvertToHashAction, fixes implementation of  
ConvertToSAction.  
Conversion actions now use RubyContext not RubyScope. This simplifies  
their calls from libraries yet causes a minor incompatibility with MRI:  
if a parameter-less method that works with a local scope, such as  
“private”, is aliased and given the name of a conversion method (“to\_s”,  
e.g.) and a conversion of an object with such aliased method is  
attempted, the scope-manipulating method fails to update the scope  
properly. This is not a real world scenario so it should be fine to  
ignore it. The fix would require to define 2 instances of each protocol  
conversion action - one HasScope flag and the other without it.

Removes more static sites.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 10, 2008, 3:23am UTC](https://www.ruby-forum.com/t/code-review-moresites4/155276/2 "2008-12-10T03:23:45Z")

</div>

DLR looks good

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 10, 2008, 4:14am UTC](https://www.ruby-forum.com/t/code-review-moresites4/155276/3 "2008-12-10T04:14:06Z")

</div>

Ruby changes look good.