# Code Review: MoreDefaultProtocols

**URL:** <https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295>\
**Category:** IronRuby\
**Created:** [October 7, 2008, 12:43am UTC](https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295 "2008-10-07T00:43:35Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 7, 2008, 12:43am UTC](https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295/1 "2008-10-07T00:43:35Z")

</div>

tfpt review “/shelveset:MoreDefaultProtocols;REDMOND\tomat”

Introduces more default protocol conversions.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 7, 2008, 1:40am UTC](https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295/2 "2008-10-07T01:40:58Z")

</div>

Some methods that were changed from object[] to MutableString[] aren’t  
tagged with [DefaultProtocol]. Is this conversion enabled by default?

Why can’t FileOps.UpdateTimes use the protocol conversion? Is to for  
semantic compatibility? (ie don’t call to\_s if the time conversion  
fails)

Looks good otherwise.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 7, 2008, 1:41am UTC](https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295/3 "2008-10-07T01:41:33Z")

</div>

The methods that take MutableString[] are not [RubyMethods] - they’re  
just helper methods.  
We don’t support [DefaultProtocol] on arrays of MutableString yet. But  
this change is the first step in that direction.

UpdateTimes have two overloads - one taking a single string and the  
other arbitrary number of arbitrary objects on which default protocol  
conversion is applied. So as soon as [DefaultProtocol] works on params  
array we can use it here.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 7, 2008, 1:43am UTC](https://www.ruby-forum.com/t/code-review-moredefaultprotocols/150295/4 "2008-10-07T01:43:53Z")

</div>

Ah, okay. I obviously missed that they weren’t RubyMethods.