# Code Review: MiscStrings

**URL:** <https://www.ruby-forum.com/t/code-review-miscstrings/184410>\
**Category:** IronRuby\
**Created:** [March 2, 2010, 3:31am UTC](https://www.ruby-forum.com/t/code-review-miscstrings/184410 "2010-03-02T03:31:09Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 2, 2010, 3:31am UTC](https://www.ruby-forum.com/t/code-review-miscstrings/184410/1 "2010-03-02T03:31:09Z")

</div>

tfpt review “/shelveset:MiscStrings;REDMOND\tomat”

A simple DLR Console Shell change:  
The version printed by the console host now recognizes Mono correctly.

Ruby changes:  
Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.  
Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913)  
Fixes -d and --version options.  
Fixes a bug in StringScanner: scan doesn’t copy the original string and  
[] uses the current value.  
Makes MutableString.GetSlice out-of-range tolerant (needed by  
StringScanner#[] fix).  
Improves performance of repeated Regex.Match called on the same input  
string.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 5, 2010, 11:29am UTC](https://www.ruby-forum.com/t/code-review-miscstrings/184410/2 "2010-03-05T11:29:19Z")

</div>

Ruby tests are fine.

JD

* * *

From: Dino Viehland  
Sent: Wednesday, March 03, 2010 11:29 AM  
To: Tomas M.; IronRuby External Code R.; Rowan Code  
Reviewers  
Cc: removed\_email\_address@domain.invalid  
Subject: RE: Code Review: MiscStrings

DLR change looks fine.

```
  _____________________________________________
  From: Tomas M.
  Sent: Monday, March 01, 2010 6:30 PM
  To: IronRuby External Code R.; Rowan Code R.
  Cc: removed_email_address@domain.invalid
  Subject: Code Review: MiscStrings

    tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

  A simple DLR Console Shell change:
  The version printed by the console host now recognizes Mono 

```

correctly.

```
  Ruby changes:
  Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
  Fixes 

```

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913)  
Fixes -d and --version options.  
Fixes a bug in StringScanner: scan doesn’t copy the original  
string and [] uses the current value.  
Makes MutableString.GetSlice out-of-range tolerant (needed by  
StringScanner#[] fix).  
Improves performance of repeated Regex.Match called on the same  
input string.

```
  Tomas

   << File: MiscStrings.diff >>

```