# Code Review: Methods6

**URL:** <https://www.ruby-forum.com/t/code-review-methods6/152369>\
**Category:** IronRuby\
**Created:** [November 3, 2008, 8:44am UTC](https://www.ruby-forum.com/t/code-review-methods6/152369 "2008-11-03T08:44:47Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 3, 2008, 8:44am UTC](https://www.ruby-forum.com/t/code-review-methods6/152369/1 "2008-11-03T08:44:47Z")

</div>

tfpt review “/shelveset:Methods6;REDMOND\tomat”  
Comment :  
Fixes bugs:

- 

```
method aliasing - aliased method has its own method attributes,

```

- 

```
module_function, private, public, protected: the attributes were 

```

not set to the “right” scopes,

- 

```
module_function - defined only singleton method, not private 

```

instance one,

- 

```
__FILE__ in eval,

```

- 

```
super call in a block in top-level code was broken,

```

- 

```
ParseTree distinguishes aliased methods and methods defined via 

```

define\_method (partially supported, to be finished).

- 

```
ParseTree lacked implementation of ArrayItemAccess node in read 

```

context,

- 

```
method_defined? didn't filter out private methods.

```

- 

```
[ironruby-Bugs-22605] TrueClass and FalseClass should be able 

```

to be reopened

Adds raw implementation of Iconv library.  
Adds GC module.  
Adds Kernel#warn and Kernel#type methods.

A bit of refactoring - groups methods in RubyUtils.  
Includes ArrayOfT shelveset, which implements “of” method for  
System::Array.

Tomas