# Code Review: gitintegration2 **URL:** \ **Category:** IronRuby\ **Created:** [December 16, 2008, 12:33am UTC](https://www.ruby-forum.com/t/code-review-gitintegration2/155722 "2008-12-16T00:33:40Z")\ **Posts on this page:** 4\ **Page:** 1
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [December 16, 2008, 12:33am UTC](https://www.ruby-forum.com/t/code-review-gitintegration2/155722/1 "2008-12-16T00:33:40Z")
tfpt review “/shelveset:gitintegration2;REDMOND\jdeville” Comment : Context.rb - Add helpers for mono and rake version - changed the is\_test? method to rely on the presence of the test environment variable instead of the value of it. git.rake - refactor to\_git - added from\_git, git:ensure\_repo, git:import - added some helper methods that will be moved to context after this is stabilized some more. - Added “testability” to the tasks. If the test environment variable is set, commands will print out instead of run. misc.rake - requires rake --version to be greater than 0.8.0 - removes requirement for tf.exe in happy. This will be reinstated after we move from SVN and have a way to specify being in a git repository. This will go in with a direct checkin since it doesn’t affect SNAP. Martin: I’ve included you to ensure that you don’t have an issue with this being checked in. It doesn’t touch anything outside of Ruby, but just wanted to be certain. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [December 16, 2008, 5:09am UTC](https://www.ruby-forum.com/t/code-review-gitintegration2/155722/2 "2008-12-16T05:09:09Z")
Reviewed with Jimmy on IRC. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [December 16, 2008, 5:30am UTC](https://www.ruby-forum.com/t/code-review-gitintegration2/155722/3 "2008-12-16T05:30:46Z")
And cleared with Martin. I’m going to check this in. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [December 16, 2008, 5:34am UTC](https://www.ruby-forum.com/t/code-review-gitintegration2/155722/4 "2008-12-16T05:34:16Z")
Looks awesome. Have you tested this on a local copy of ironruby/ironruby.git, or your own fork? * * * From: removed\_email\_address@domain.invalid [removed\_email\_address@domain.invalid] On Behalf Of Jim D. [removed\_email\_address@domain.invalid] Sent: Monday, December 15, 2008 3:31 PM To: IronRuby External Code R. Cc: removed\_email\_address@domain.invalid; Martin Maly Subject: [Ironruby-core] Code Review: gitintegration2 tfpt review “/shelveset:gitintegration2;REDMOND\jdeville” Comment : Context.rb - Add helpers for mono and rake version - changed the is\_test? method to rely on the presence of the test environment variable instead of the value of it. git.rake - refactor to\_git - added from\_git, git:ensure\_repo, git:import - added some helper methods that will be moved to context after this is stabilized some more. - Added “testability” to the tasks. If the test environment variable is set, commands will print out instead of run. misc.rake - requires rake --version to be greater than 0.8.0 - removes requirement for tf.exe in happy. This will be reinstated after we move from SVN and have a way to specify being in a git repository. This will go in with a direct checkin since it doesn’t affect SNAP. Martin: I’ve included you to ensure that you don’t have an issue with this being checked in. It doesn’t touch anything outside of Ruby, but just wanted to be certain.