# Code Review: G19.Final **URL:** \ **Category:** IronRuby\ **Created:** [August 17, 2010, 3:17am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396 "2010-08-17T03:17:40Z")\ **Posts on this page:** 10\ **Page:** 1
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 3:17am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/1 "2010-08-17T03:17:40Z")
tfpt review “/shelveset:G19.Final;REDMOND\tomat” Comment : Implements many 1.9 features and changes: - Syntax - should now be fully compatible with 1.9.2. - Semantics - many fixes, some features still not completed: o Passing optional and block parameters to blocks o Compound parameters unpacking, e.g. def foo((a, b), c); end - Various small changes in libraries. Removes version command line switches (-1.9, -1.8). The only supported MRI version is 1.9 from now on. I’ve kept RubyCompatibility enum for now, but it should be removed along with all 1.8 specific features. Since we are still missing a lot of 1.9 features many failing tests and specs needs to be disabled for now (including Rails, Rubygems, and Rack). Tomas ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 3:42am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/2 "2010-08-17T03:42:51Z")
This change might break apps that already worked with IronRuby v1.0 or v1.1. The reason might be: - IronRuby is now using 1.9.1 standard libraries, which might depend on 1.9 features that are not yet implemented in IronRuby or are implemented incorrectly. or - the app uses 1.8 specific feature that is no longer supported in 1.9 (might be a grammar change or change in runtime behavior). If you need a stable IronRuby build that is compatible with 1.8.6 please use IronRuby v1.0 or v1.1 released in July. IronRuby v1.1 isn’t as stable as v1.0 but is still compatible with 1.8.6. And as usual, contributions are welcome. Should you find a missing 1.9 feature don’t hesitate, implement it and submit a patch! Tomas ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 5:01am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/3 "2010-08-17T05:01:18Z")
Nice work! Thanks Tomas On Tue, Aug 17, 2010 at 1:42 PM, Tomas M. \< ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 5:53am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/4 "2010-08-17T05:53:22Z")
WOW! Did I read that right? It’s “fully compatible with 1.9.2”? Tomas, thank you. You are a machine. Three cheers! Ryan R. On Mon, Aug 16, 2010 at 6:16 PM, Tomas M. \< ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 6:09am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/5 "2010-08-17T06:09:45Z")
Don’t get too excited ☺, there is still a lot of work to be done in libraries and some in runtime to run all Ruby 1.9 apps. Tomas From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Ryan R. Sent: Monday, August 16, 2010 8:52 PM To: removed\_email\_address@domain.invalid Subject: Re: [Ironruby-core] Code Review: G19.Final WOW! Did I read that right? It’s “fully compatible with 1.9.2”? Tomas, thank you. You are a machine. Three cheers! Ryan R. On Mon, Aug 16, 2010 at 6:16 PM, Tomas M. \ wrote: tfpt review “/shelveset:G19.Final;REDMOND\tomat” Comment : Implements many 1.9 features and changes: - ``` Syntax - should now be fully compatible with 1.9.2. ``` - ``` Semantics - many fixes, some features still not completed: o Passing optional and block parameters to blocks o Compound parameters unpacking, e.g. def foo((a, b), c); ``` end - ``` Various small changes in libraries. ``` Removes version command line switches (-1.9, -1.8). The only supported MRI version is 1.9 from now on. I’ve kept RubyCompatibility enum for now, but it should be removed along with all 1.8 specific features. Since we are still missing a lot of 1.9 features many failing tests and specs needs to be disabled for now (including Rails, Rubygems, and Rack). Tomas * * * Ironruby-core mailing list removed\_email\_address@domain.invalid[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 3:54pm UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/6 "2010-08-17T15:54:39Z")
This is exciting news though, progress is good! On Tue, Aug 17, 2010 at 12:07 AM, Tomas M. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Ryan R. > > - > > ``` > Syntax - should now be fully compatible with 1.9.2. > > ``` > > * * * > > Ironruby-core mailing list > [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) – Michael L. IronRuby MVP > **[Michael Letterle's Blog ·](https://blog.prokrams.com/)** ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 17, 2010, 6:59pm UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/7 "2010-08-17T18:59:44Z")
Awesome, Tomas! I have no excuse now for not submitting some patches ;). -Charles On Mon, Aug 16, 2010 at 8:16 PM, Tomas M. \< ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 19, 2010, 10:44am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/8 "2010-08-19T10:44:51Z")
I guess those changes have not made it to the git repository yet, right? Anyway that’s some great news, thanks again for all the awesome work! On Tue, Aug 17, 2010 at 03:42, Tomas M. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > Â - Â Â Syntax - should now be fully compatible with 1.9.2. > > * * * > > Ironruby-core mailing list > [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) – Daniele A. > **[clorophilla.net](https://clorophilla.net/)** [http://twitter.com/JoL1hAHN](http://twitter.com/JoL1hAHN) ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 19, 2010, 11:11am UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/9 "2010-08-19T11:11:12Z")
They did. [http://github.com/ironruby/ironruby/commit/01a1d31f2dde357194c2f5caccdc8ead06033791](http://github.com/ironruby/ironruby/commit/01a1d31f2dde357194c2f5caccdc8ead06033791) I forgot to attach a git comment to this shelveset, so unfortunately it just says “Sync to TFS changeset #”. Tomas ---
**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\ **Post date:** [August 19, 2010, 10:04pm UTC](https://www.ruby-forum.com/t/code-review-g19-final/193396/10 "2010-08-19T22:04:38Z")
Thanks, actually it was just my local repository that (for some reason) was still stuck to the commits pushed on date 2010-08-16. On Thu, Aug 19, 2010 at 10:52, Tomas M. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > Sent: Thursday, August 19, 2010 1:02 AM > > > - the app uses 1.8 specific feature that is no longer supported in 1.9 (might be a grammar change or change in runtime behavior). > > To: IronRuby External Code R. > > end > > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) > > [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) > > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) > > * * * > > Ironruby-core mailing list > [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) – Daniele A. > **[clorophilla.net](https://clorophilla.net/)** [http://twitter.com/JoL1hAHN](http://twitter.com/JoL1hAHN)