# Code Review: FastFixes1

**URL:** <https://www.ruby-forum.com/t/code-review-fastfixes1/138889>\
**Category:** IronRuby\
**Created:** [May 28, 2008, 5:44pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889 "2008-05-28T17:44:50Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 28, 2008, 5:44pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/1 "2008-05-28T17:44:50Z")

</div>

tfpt review “/shelveset:FastFixes1;REDMOND\curth”

Fixed critical error in Dir.glob  
Added File.split  
Added stub for BigDecimal class

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 28, 2008, 6:12pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/2 "2008-05-28T18:12:03Z")

</div>

Missing a few method return bangs in BigDecimalOps.cs

I guess you’re going to implement Kernel#BigDecimal eventually …

Otherwise looks good!

Thanks,  
-John

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 29, 2008, 10:32pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/3 "2008-05-29T22:32:52Z")

</div>

Tomas has already fixed that here :(. As you might imagine, our desire  
to astound and amaze the audience at RailsConf has led to some shortcuts  
getting taken with respect to the code reviews going out to this list.  
This will certainly not be the case post-conference once we start fixing  
the “community” part of this “community project”.

Disclaimer: by “astound and amaze” I mean “keep from getting laughed out  
of the room”.

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 29, 2008, 10:25pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/4 "2008-05-29T22:25:11Z")

</div>

This bit doesn’t work:

- [RubyModule(Extends = typeof(Kernel))]
- public static class KernelOps {
- 

```
   [RubyMethod("BigDecimal", 

```

RubyMethodAttributes.PrivateInstance)]

- 

```
   [RubyMethod("BigDecimal", 

```

RubyMethodAttributes.PublicSingleton)]

- 

```
   public static object CreateBigDecimal(CodeContext/*!*/ context,

```

object self, [NotNull]MutableString/_!_/ value) {

- 

```
       return BigDecimalOps.Create(context, value);

```

- 

```
   }

```

- 
- 

```
   [RubyMethod("BigDecimal", 

```

RubyMethodAttributes.PrivateInstance)]

- 

```
   [RubyMethod("BigDecimal", 

```

RubyMethodAttributes.PublicSingleton)]

- 

```
   public static object CreateBigDecimal(CodeContext/*!*/ context,

```

object self, object value) {

- 

```
       return BigDecimalOps.Create(context, value);

```

- 

```
   }

```

- }  
+}

The initializer code builds up the methods nicely but the “Kernel”  
module is  
not in RubyExecutionContext.\_moduleCache, so the methods don’t get added  
to  
Kernel (but instead added to a Module called Ruby::Builtins::Kernel.

Any help here?  
Cheers,  
Pete

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 29, 2008, 10:54pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/5 "2008-05-29T22:54:04Z")

</div>

Great! No problem.

(I appreciate that this is not a big deal at the moment but I thought I  
was  
missing something.)

I am continually “astounded and amazed”.

Keep up the hard work. These code reviews, if nothing else, really give  
us  
a feeling that there is loads of graft going on. Hopefully that will  
keep  
some of the moaners off your back…

Ta  
Pete

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [May 29, 2008, 11:48pm UTC](https://www.ruby-forum.com/t/code-review-fastfixes1/138889/6 "2008-05-29T23:48:41Z")

</div>

Hopefully after RailsConf (this weekend) and TechEd (next week). We can  
do some work on automating the repository syncing, and setting up a  
binary drop. We’ll have to discuss some of those details at that time.

JD