# Code Review: Equality

**URL:** <https://www.ruby-forum.com/t/code-review-equality/182943>\
**Category:** IronRuby\
**Created:** [February 5, 2010, 3:01am UTC](https://www.ruby-forum.com/t/code-review-equality/182943 "2010-02-05T03:01:20Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [February 5, 2010, 3:01am UTC](https://www.ruby-forum.com/t/code-review-equality/182943/1 "2010-02-05T03:01:20Z")

</div>

tfpt review “/shelveset:Equality;REDMOND\tomat”  
Comment :  
Fixes comparisons of hashes, arrays and strings to behave according to  
[http://redmine.ruby-lang.org/repositories/revision/2?rev=3442](http://redmine.ruby-lang.org/repositories/revision/2?rev=3442)

Adds specs for this behavior.

Also fixes:  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3565](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3565)

(the failures are not critical any more, our behavior is now the same  
as 1.8.6).

Fixes interop test assembly build so that it works on machine with  
VS2010.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [February 5, 2010, 9:01pm UTC](https://www.ruby-forum.com/t/code-review-equality/182943/2 "2010-02-05T21:01:12Z")

</div>

Test changes look good.