# Code Review: Encs2

**URL:** <https://www.ruby-forum.com/t/code-review-encs2/184668>\
**Category:** IronRuby\
**Created:** [March 6, 2010, 5:28am UTC](https://www.ruby-forum.com/t/code-review-encs2/184668 "2010-03-06T05:28:15Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 6, 2010, 5:28am UTC](https://www.ruby-forum.com/t/code-review-encs2/184668/1 "2010-03-06T05:28:15Z")

</div>

tfpt review “/shelveset:Encs2;REDMOND\tomat”  
Comment :

Fixes bunch of encoding issues including  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3920](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3920).  
Fixes handling of DST transitions in Time operators.  
Fixes bug in Array:  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3314](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3314)

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 6, 2010, 5:39am UTC](https://www.ruby-forum.com/t/code-review-encs2/184668/2 "2010-03-06T05:39:22Z")

</div>

Please check newlines in the tags file, looks like 2 lines got joined.  
Nice catch in each\_char.rb

Rest looks good from hear.

JD