# Code Review: DMO1

**URL:** <https://www.ruby-forum.com/t/code-review-dmo1/163059>\
**Category:** IronRuby\
**Created:** [March 17, 2009, 2:46am UTC](https://www.ruby-forum.com/t/code-review-dmo1/163059 "2009-03-17T02:46:21Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 17, 2009, 2:46am UTC](https://www.ruby-forum.com/t/code-review-dmo1/163059/1 "2009-03-17T02:46:21Z")

</div>

tfpt review “/shelveset:DMO1;REDMOND\tomat”  
Comment :

- Checks for an invalid number of arguments is passed to an attribute  
setter/getter or struct field setter/getter.
- Implements correct splatting of arguments to Delegate constructor  
and enables previously failing tests.
- Refactors RubyMethodGroupBase in preparation for obsolete API usage  
removal.
- Fixes a comment and adds OBSOLETE comments to obsolete API of  
MethodBinder and BindingTarget classes.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 17, 2009, 5:27pm UTC](https://www.ruby-forum.com/t/code-review-dmo1/163059/2 "2009-03-17T17:27:56Z")

</div>

In RubyClass.cs, there’s an incorrect parameter passed to  
SetWrongNumber:

var actualArgs = RubyMethodGroupBase.NormalizeArguments(metaBuilder,  
args, SelfCallConvention.NoSelf, false, false);  
if (actualArgs.Length == 1) {  
…  
} else {  
metaBuilder.SetWrongNumberOfArgumentsError(actualArgs.Length, 0);  
\<-- should be “1”.  
}

Looks good otherwise.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [March 17, 2009, 6:44pm UTC](https://www.ruby-forum.com/t/code-review-dmo1/163059/3 "2009-03-17T18:44:55Z")

</div>

Good catch. Will fix it in the next changeset.

Tomas