# Code Review: DirFix

**URL:** <https://www.ruby-forum.com/t/code-review-dirfix/146818>\
**Category:** IronRuby\
**Created:** [August 25, 2008, 9:41pm UTC](https://www.ruby-forum.com/t/code-review-dirfix/146818 "2008-08-25T21:41:24Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Srivatsn\_Narayanan](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/9fc29f/32.png) [@Srivatsn\_Narayanan](https://www.ruby-forum.com/u/Srivatsn_Narayanan)\
**Post date:** [August 25, 2008, 9:41pm UTC](https://www.ruby-forum.com/t/code-review-dirfix/146818/1 "2008-08-25T21:41:24Z")

</div>

Tfpt review /shelveset:DirFix;srivatsn

Fixes RubyForge [#21126] Dir.glob \*\*/ returns duplicate entries.

The code was enumerating the current folder’s and its subfolders’ files  
recursively and hence everything got counted twice. The fix tracks that  
with a flag.

---

<div class="post-metadata">

**Author:** ![Srivatsn\_Narayanan](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/9fc29f/32.png) [@Srivatsn\_Narayanan](https://www.ruby-forum.com/u/Srivatsn_Narayanan)\
**Post date:** [August 25, 2008, 9:55pm UTC](https://www.ruby-forum.com/t/code-review-dirfix/146818/2 "2008-08-25T21:55:29Z")

</div>

Looks good.

Tomas

From: Srivatsn Narayanan  
Sent: Monday, August 25, 2008 12:41 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Code Review: DirFix

Tfpt review /shelveset:DirFix;srivatsn

Fixes RubyForge [#21126] Dir.glob \*\*/ returns duplicate entries.

The code was enumerating the current folder’s and its subfolders’ files  
recursively and hence everything got counted twice. The fix tracks that  
with a flag.