# Code Review: Dir4

**URL:** <https://www.ruby-forum.com/t/code-review-dir4/181168>\
**Category:** IronRuby\
**Created:** [January 6, 2010, 7:55pm UTC](https://www.ruby-forum.com/t/code-review-dir4/181168 "2010-01-06T19:55:13Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [January 6, 2010, 7:55pm UTC](https://www.ruby-forum.com/t/code-review-dir4/181168/1 "2010-01-06T19:55:13Z")

</div>

tfpt review “/shelveset:Dir4;REDMOND\tomat”  
Comment :  
DLR, Python:

- Adds more file system APIs to PAL. Obsoletes virtual methods  
GetFiles and GetDirectories in favor of GetFileSystemEntries.

Ruby:

- Fixes some Dir specs, adds support for Unicode file/directory  
names.
- Changes Dir and File methods to use PAL for file system operations.  
Adds Dir tests exercising a custom virtual file system.
- Fixes encoding of file paths. This might fix some of the reported  
System::Text::DecoderFallbackException issues  
([http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2931](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2931))
- Fixes issues with -v command line option.
- Fixes bugs in methods using MutableString.GetByteArray.
- Fixes MutableString#inspect and dump to handle strings with  
incomplete UTF16 characters.
- Fixes bugs in glob.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [January 12, 2010, 11:50am UTC](https://www.ruby-forum.com/t/code-review-dir4/181168/2 "2010-01-12T11:50:46Z")

</div>

I know I’m late on this, but test looks good too.

JD