# Code Review: Defined

**URL:** <https://www.ruby-forum.com/t/code-review-defined/176914>\
**Category:** IronRuby\
**Created:** [October 8, 2009, 4:41am UTC](https://www.ruby-forum.com/t/code-review-defined/176914 "2009-10-08T04:41:42Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 8, 2009, 4:41am UTC](https://www.ruby-forum.com/t/code-review-defined/176914/1 "2009-10-08T04:41:42Z")

</div>

tfpt review “/shelveset:Defined;REDMOND\tomat”  
Comment :  
Implements defined?(super) and fixes defined? applied on a method call  
to respect visibility.

Fixes:  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1354](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1354)

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 8, 2009, 8:46am UTC](https://www.ruby-forum.com/t/code-review-defined/176914/2 "2009-10-08T08:46:55Z")

</div>

Looks good to me

* * *

From: Tomas M.  
Sent: Wednesday, October 07, 2009 7:40 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Code Review: Defined

tfpt review “/shelveset:Defined;REDMOND\tomat”  
Comment :  
Implements defined?(super) and fixes defined? applied on a method call  
to respect visibility.

Fixes:  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1354](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1354)

Tomas