# Code Review: core/module/autoload

**URL:** <https://www.ruby-forum.com/t/code-review-core-module-autoload/166040>\
**Category:** IronRuby\
**Created:** [April 21, 2009, 8:52am UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040 "2009-04-21T08:52:48Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 21, 2009, 8:52am UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040/1 "2009-04-21T08:52:48Z")

</div>

[http://github.com/jschementi/ironruby/commit/bbfa3c4a35cc331e58fb9da9a4097de86ed0dbff](http://github.com/jschementi/ironruby/commit/bbfa3c4a35cc331e58fb9da9a4097de86ed0dbff)

autoload uses ‘/’ to join load-path and autoload-path.  
Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=674](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=674)

This makes Rails 2.3.2 startup without any modifications! =)

## Changes:

## Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/autoload\_spec.rb

Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/autoload\_join.rb

- Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs

---

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 21, 2009, 9:35am UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040/2 "2009-04-21T09:35:00Z")

</div>

Looks good.

JD

---

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 21, 2009, 5:37pm UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040/3 "2009-04-21T17:37:23Z")

</div>

/ is not appended if the path ends with /. It is if it ends with \ -  
which seems like a bug in Ruby that we shouldn’t copy.  
Could you rather implement " Combine" somewhere (in RubyUtils e.g.) that  
uses / for joining paths but checks if the directory ends with \ or /?

Tomas

---

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 22, 2009, 8:59pm UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040/4 "2009-04-22T20:59:29Z")

</div>

[http://github.com/jschementi/ironruby/commit/78bd7541cebae33b3b07bfed17ce74a63ecb49d4](http://github.com/jschementi/ironruby/commit/78bd7541cebae33b3b07bfed17ce74a63ecb49d4)

Code review updates:

- Don’t combine paths with ‘/’ if the base-path already ends with ‘/’ or  
‘\’

---

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 22, 2009, 9:18pm UTC](https://www.ruby-forum.com/t/code-review-core-module-autoload/166040/5 "2009-04-22T21:18:55Z")

</div>

Looks good.

Tomas