# Code Review: core/env/clear

**URL:** <https://www.ruby-forum.com/t/code-review-core-env-clear/166319>\
**Category:** IronRuby\
**Created:** [April 23, 2009, 8:54pm UTC](https://www.ruby-forum.com/t/code-review-core-env-clear/166319 "2009-04-23T20:54:22Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Tim\_CSSSDO](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/t/aeb1de/32.png) [@Tim\_CSSSDO](https://www.ruby-forum.com/u/Tim_CSSSDO)\
**Post date:** [April 23, 2009, 8:54pm UTC](https://www.ruby-forum.com/t/code-review-core-env-clear/166319/1 "2009-04-23T20:54:22Z")

</div>

Hi all!

I’ve just started to learn IronRuby a week or two before, and Shri  
showed me through screenshare about mspec and fixing rubyspec bugs in  
general.

So for my first contribution, I just did a one line change to know the  
process better.

Here it is:

[http://github.com/tnachen/ironruby/commit/81ff26cb1e462ab11c0bbaad634147be60c30eff](http://github.com/tnachen/ironruby/commit/81ff26cb1e462ab11c0bbaad634147be60c30eff)

I changed the rubyspec for core\env\clear, as it was having a typo and  
also it fails because the empty ENV variable as an object cannot equal  
to an empty {} hash.

Shri suggested to use ENV.size instead, and that’s what I’ve put in.

Please let me know if I need to do anything else!

Thank you!

Tim

---

<div class="post-metadata">

**Author:** ![Tim\_CSSSDO](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/t/aeb1de/32.png) [@Tim\_CSSSDO](https://www.ruby-forum.com/u/Tim_CSSSDO)\
**Post date:** [April 23, 2009, 9:09pm UTC](https://www.ruby-forum.com/t/code-review-core-env-clear/166319/2 "2009-04-23T21:09:40Z")

</div>

Looks good! Good to see that you’ve found your way around 🙂

JD

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Tim C. (SDO)  
Sent: Thursday, April 23, 2009 11:53 AM  
To: removed\_email\_address@domain.invalid  
Subject: [Ironruby-core] Code Review: core/env/clear

Hi all!

I’ve just started to learn IronRuby a week or two before, and Shri  
showed me through screenshare about mspec and fixing rubyspec bugs in  
general.

So for my first contribution, I just did a one line change to know the  
process better.

Here it is:

[http://github.com/tnachen/ironruby/commit/81ff26cb1e462ab11c0bbaad634147be60c30eff](http://github.com/tnachen/ironruby/commit/81ff26cb1e462ab11c0bbaad634147be60c30eff)

I changed the rubyspec for core\env\clear, as it was having a typo and  
also it fails because the empty ENV variable as an object cannot equal  
to an empty {} hash.

Shri suggested to use ENV.size instead, and that’s what I’ve put in.

Please let me know if I need to do anything else!

Thank you!

Tim