# Code Review: ClrInteropBugFixes

**URL:** <https://www.ruby-forum.com/t/code-review-clrinteropbugfixes/169303>\
**Category:** IronRuby\
**Created:** [June 2, 2009, 3:53am UTC](https://www.ruby-forum.com/t/code-review-clrinteropbugfixes/169303 "2009-06-02T03:53:33Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 2, 2009, 3:53am UTC](https://www.ruby-forum.com/t/code-review-clrinteropbugfixes/169303/1 "2009-06-02T03:53:33Z")

</div>

tfpt review “/shelveset:ClrInteropBugFixes;REDMOND\tomat”

Simple DLR changes

Ruby bug fixes:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:)  
load\_assembly(\<partial\_name\>) should work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:)  
WinForms broken  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:)  
System.Action.new does not work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:) Passing  
a Ruby array to a .NET method that expects an IEnumerable derivative  
fails with GetEnumerator call

- fixes incorrect caching of TypeGroup#new.

Class#clr\_member no longer throws an exception if called on Ruby class -  
it returns a group of all inherited CLR methods of given name (if there  
are any).  
Improves display name of generic types: e.g. Action displays as  
System::Action[Fixnum].

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 2, 2009, 4:12am UTC](https://www.ruby-forum.com/t/code-review-clrinteropbugfixes/169303/2 "2009-06-02T04:12:16Z")

</div>

Adding one more bug fix:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1470](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1470) : Can’t  
call the BigIntegerOverload of a method with a DefaultProtocol Attribute  
on the BigInteger attribute

- Bignum.new(1) should call method\_missing:

irb(main):001:0\> Bignum.new(1)  
NoMethodError: undefined method `new’ for Bignum:Class

Tomas

From: Tomas M.  
Sent: Monday, June 01, 2009 6:47 PM  
To: IronRuby External Code R.; Rowan Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Code Review: ClrInteropBugFixes

tfpt review “/shelveset:ClrInteropBugFixes;REDMOND\tomat”

Simple DLR changes

Ruby bug fixes:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:)  
load\_assembly(\<partial\_name\>) should work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:)  
WinForms broken  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:)  
System.Action.new does not work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:) Passing  
a Ruby array to a .NET method that expects an IEnumerable derivative  
fails with GetEnumerator call

- fixes incorrect caching of TypeGroup#new.

Class#clr\_member no longer throws an exception if called on Ruby class -  
it returns a group of all inherited CLR methods of given name (if there  
are any).  
Improves display name of generic types: e.g. Action displays as  
System::Action[Fixnum].

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [June 2, 2009, 6:29pm UTC](https://www.ruby-forum.com/t/code-review-clrinteropbugfixes/169303/3 "2009-06-02T18:29:14Z")

</div>

Looks good!

From: Tomas M.  
Sent: Monday, June 01, 2009 7:06 PM  
To: Tomas M.; IronRuby External Code R.; Rowan Code  
Reviewers  
Cc: removed\_email\_address@domain.invalid  
Subject: RE: Code Review: ClrInteropBugFixes

Adding one more bug fix:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1470](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1470) : Can’t  
call the BigIntegerOverload of a method with a DefaultProtocol Attribute  
on the BigInteger attribute

- Bignum.new(1) should call method\_missing:

irb(main):001:0\> Bignum.new(1)  
NoMethodError: undefined method `new’ for Bignum:Class

Tomas

From: Tomas M.  
Sent: Monday, June 01, 2009 6:47 PM  
To: IronRuby External Code R.; Rowan Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Code Review: ClrInteropBugFixes

tfpt review “/shelveset:ClrInteropBugFixes;REDMOND\tomat”

Simple DLR changes

Ruby bug fixes:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1345:)  
load\_assembly(\<partial\_name\>) should work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1501:)  
WinForms broken  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1344:)  
System.Action.new does not work  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=917:) Passing  
a Ruby array to a .NET method that expects an IEnumerable derivative  
fails with GetEnumerator call

- fixes incorrect caching of TypeGroup#new.

Class#clr\_member no longer throws an exception if called on Ruby class -  
it returns a group of all inherited CLR methods of given name (if there  
are any).  
Improves display name of generic types: e.g. Action displays as  
System::Action[Fixnum].

Tomas
