# Code Review: bugfixes1

**URL:** <https://www.ruby-forum.com/t/code-review-bugfixes1/160025>\
**Category:** IronRuby\
**Created:** [February 11, 2009, 3:07am UTC](https://www.ruby-forum.com/t/code-review-bugfixes1/160025 "2009-02-11T03:07:22Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 11, 2009, 3:07am UTC](https://www.ruby-forum.com/t/code-review-bugfixes1/160025/1 "2009-02-11T03:07:22Z")

</div>

tfpt review “/shelveset:bugfixes1;REDMOND\jdeville”  
Comment :  
BinaryEncoding changes to help mono compilation, thanks to M.  
Letterle. Changes in FileOps to fix File.dirname (Rubyforge bugs 23669  
and 22167), thanks to Ivan Porto C… Tag changes for the FileOps  
fix.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 11, 2009, 4:09am UTC](https://www.ruby-forum.com/t/code-review-bugfixes1/160025/2 "2009-02-11T04:09:57Z")

</div>

Reviewed by JSchementi via IRC

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [February 11, 2009, 4:29am UTC](https://www.ruby-forum.com/t/code-review-bugfixes1/160025/3 "2009-02-11T04:29:14Z")

</div>

Looks good. Removing tags is good =)