# Code Review: bindingandyamlfxcop

**URL:** <https://www.ruby-forum.com/t/code-review-bindingandyamlfxcop/182700>\
**Category:** IronRuby\
**Created:** [February 1, 2010, 5:56pm UTC](https://www.ruby-forum.com/t/code-review-bindingandyamlfxcop/182700 "2010-02-01T17:56:52Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [February 1, 2010, 5:56pm UTC](https://www.ruby-forum.com/t/code-review-bindingandyamlfxcop/182700/1 "2010-02-01T17:56:52Z")

</div>

tfpt review “/shelveset:bindingandyamlfxcop;REDMOND\tomat”  
Comment :  
Kernel#binding captures receiver and eval uses it as “self”.  
Adds FxCop configuration to yaml .csproj.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [February 1, 2010, 8:05pm UTC](https://www.ruby-forum.com/t/code-review-bindingandyamlfxcop/182700/2 "2010-02-01T20:05:07Z")

</div>

Basic test changes look good. Thanks for adding FXCop.

Do we have specs for these changes? Or a bug so that I know what needs  
to be regressed?

JD

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [February 1, 2010, 9:27pm UTC](https://www.ruby-forum.com/t/code-review-bindingandyamlfxcop/182700/3 "2010-02-01T21:27:40Z")

</div>

I’ve added unit tests. There are probably no specs in Ruby suite. Note  
that 1.9 and 1.8 behaviors are different.

Tomas