# Code Review: BFX.1

**URL:** <https://www.ruby-forum.com/t/code-review-bfx-1/177440>\
**Category:** IronRuby\
**Created:** [October 17, 2009, 4:25am UTC](https://www.ruby-forum.com/t/code-review-bfx-1/177440 "2009-10-17T04:25:26Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 17, 2009, 4:25am UTC](https://www.ruby-forum.com/t/code-review-bfx-1/177440/1 "2009-10-17T04:25:26Z")

</div>

tfpt review “/shelveset:BFX.1;REDMOND\tomat”  
Comment :  
DLR:  
Fixes ErrorSink to throw SyntaxErrorException only if the severity is  
FatalError or Error (i.e. not for warnings).

Ruby:  
Fixes bugs:

[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2514](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2514)  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2654](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2654)  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1878](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1878)  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1357](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1357)  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2609](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2609)

Tomas