# Code Review: BacktraceFix

**URL:** <https://www.ruby-forum.com/t/code-review-backtracefix/149911>\
**Category:** IronRuby\
**Created:** [October 1, 2008, 2:27am UTC](https://www.ruby-forum.com/t/code-review-backtracefix/149911 "2008-10-01T02:27:35Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 1, 2008, 2:27am UTC](https://www.ruby-forum.com/t/code-review-backtracefix/149911/1 "2008-10-01T02:27:35Z")

</div>

tfpt review “/shelveset:BacktraceFix;REDMOND\tomat”  
Comment :  
Backtraces weren’t handled correctly for rethrown exceptions.  
Adds some tests for backtraces and modifies the infrastructure to run  
unit tests in all combinations of /interpret and /partial modes.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 1, 2008, 5:54am UTC](https://www.ruby-forum.com/t/code-review-backtracefix/149911/2 "2008-10-01T05:54:42Z")

</div>

Test changes look good.

JD

* * *

From: removed\_email\_address@domain.invalid  
[removed\_email\_address@domain.invalid] On Behalf Of Tomas M.  
[removed\_email\_address@domain.invalid]  
Sent: Tuesday, September 30, 2008 5:26 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: [Ironruby-core] Code Review: BacktraceFix

tfpt review “/shelveset:BacktraceFix;REDMOND\tomat”  
Comment :  
Backtraces weren’t handled correctly for rethrown exceptions.  
Adds some tests for backtraces and modifies the infrastructure to run  
unit tests in all combinations of /interpret and /partial modes.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 1, 2008, 4:56pm UTC](https://www.ruby-forum.com/t/code-review-backtracefix/149911/3 "2008-10-01T16:56:26Z")

</div>

Both overloads of RubyExceptionData.AddBacktrace take skipFrames as a  
reference parameter, but it doesn’t look like any of the call sites care  
about the modified value. Looks good otherwise.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [October 1, 2008, 7:21pm UTC](https://www.ruby-forum.com/t/code-review-backtracefix/149911/4 "2008-10-01T19:21:32Z")

</div>

One of the overload is called in CreateBacktrace and ref skipFrames is  
used there.  
You’re right about the other overload. I used the same pattern for  
consistency.

Tomas