# Code Review: Allows symbols to be in a YAML array **URL:** \ **Category:** IronRuby\ **Created:** [April 12, 2009, 1:42am UTC](https://www.ruby-forum.com/t/code-review-allows-symbols-to-be-in-a-yaml-array/165311 "2009-04-12T01:42:14Z")\ **Posts on this page:** 4\ **Page:** 1
**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\ **Post date:** [April 12, 2009, 1:42am UTC](https://www.ruby-forum.com/t/code-review-allows-symbols-to-be-in-a-yaml-array/165311/1 "2009-04-12T01:42:14Z")
[http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609) Allows symbols to be in a YAML array (“date: [:year, :month, :day]”). Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375). (Shri: gitdiff wasn’t working for me, is there any setup I need to do?) ---
**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\ **Post date:** [April 13, 2009, 7:50am UTC](https://www.ruby-forum.com/t/code-review-allows-symbols-to-be-in-a-yaml-array/165311/2 "2009-04-13T07:50:01Z")
GitDiff.bat just builds on top of the GIT\_EXTERNAL\_DIFF environment variable mentioned at [http://kernel.org/pub/software/scm/git/docs/v1.0.13/git-diff-files.html](http://kernel.org/pub/software/scm/git/docs/v1.0.13/git-diff-files.html). Can you do “set GIT\_EXTERNAL\_DIFF=echo” and then run a “git diff” command. If that runs to completion, GitDiff.bat should work as well. We can take a look tomorrow… Shri From: Jimmy S. Sent: Saturday, April 11, 2009 4:42 PM To: removed\_email\_address@domain.invalid Cc: IronRuby External Code R. Subject: Code Review: Allows symbols to be in a YAML array [http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609) Allows symbols to be in a YAML array (“date: [:year, :month, :day]”). Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375). (Shri: gitdiff wasn’t working for me, is there any setup I need to do?) ---
**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\ **Post date:** [April 14, 2009, 9:02pm UTC](https://www.ruby-forum.com/t/code-review-allows-symbols-to-be-in-a-yaml-array/165311/3 "2009-04-14T21:02:15Z")
In the spec, why not use each\_with\_index instead of times? ([http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99)) Other than that, looks good. JD From: Jimmy S. Sent: Saturday, April 11, 2009 4:42 PM To: removed\_email\_address@domain.invalid Cc: IronRuby External Code R. Subject: Code Review: Allows symbols to be in a YAML array [http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609) Allows symbols to be in a YAML array (“date: [:year, :month, :day]”). Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375). (Shri: gitdiff wasn’t working for me, is there any setup I need to do?) ---
**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\ **Post date:** [April 16, 2009, 12:22am UTC](https://www.ruby-forum.com/t/code-review-allows-symbols-to-be-in-a-yaml-array/165311/4 "2009-04-16T00:22:23Z")
File.dirname now uses [NotNull] instead of an explicit check on path: [http://github.com/jschementi/ironruby/commit/8235f4861f0afb70c504472e697565080ffdb3c8](http://github.com/jschementi/ironruby/commit/8235f4861f0afb70c504472e697565080ffdb3c8) Jim said spec changes were fine. This is in my master github branch now, and Jim is pulling it in to the main repo shortly. One more bug fix (autoload) left until Rails starts! From: Jim D. Sent: Tuesday, April 14, 2009 11:45 AM To: Jimmy S.; removed\_email\_address@domain.invalid Cc: IronRuby External Code R. Subject: RE: Code Review: Allows symbols to be in a YAML array In the spec, why not use each\_with\_index instead of times? ([http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99)) Other than that, looks good. JD From: Jimmy S. Sent: Saturday, April 11, 2009 4:42 PM To: removed\_email\_address@domain.invalid Cc: IronRuby External Code R. Subject: Code Review: Allows symbols to be in a YAML array [http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609](http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609) Allows symbols to be in a YAML array (“date: [:year, :month, :day]”). Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375). (Shri: gitdiff wasn’t working for me, is there any setup I need to do?)