# Code Review: ActiveRecord fixes

**URL:** <https://www.ruby-forum.com/t/code-review-activerecord-fixes/183107>\
**Category:** IronRuby\
**Created:** [February 8, 2010, 10:04am UTC](https://www.ruby-forum.com/t/code-review-activerecord-fixes/183107 "2010-02-08T10:04:17Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [February 8, 2010, 10:04am UTC](https://www.ruby-forum.com/t/code-review-activerecord-fixes/183107/1 "2010-02-08T10:04:17Z")

</div>

tfpt review “/shelveset:ar;REDMOND\sborde”

Comment :

Fixed issue with extra 0s being appended to id. This was being caused  
by a bug in BigDecimal#to\_i

Fixed issue in ironruby-dbi with Statement#fetch being called after  
the reader was closed

Fixed issue in ironruby-dbi where multiple Statements were active for  
a connection. We need to close the previous Statement first

Will follow up to get these fixes into the ironruby-dbi gem

Modified “utr -i foo” to generate tags to disable failing test in the  
utr\foo\_tests.rb file itself. This way, it is possible to run “utr -i  
foo” in a loop and generate tags for all flaky tests (ie. tests which  
fail non-deterministically)

Enabling the ActiveRecord tests in irtests (assuming they pass  
consistently in the over-night run tonight on my machine)

This puts the pass rate at around 95% (116 tests disabled out of a  
total of 2123 tests)

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [February 8, 2010, 6:00pm UTC](https://www.ruby-forum.com/t/code-review-activerecord-fixes/183107/2 "2010-02-08T18:00:10Z")

</div>

Code change looks good.

Tomas