# Bad Smells sing in a rails application

**URL:** <https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952>\
**Category:** Rails\
**Created:** [June 27, 2007, 8:17pm UTC](https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952 "2007-06-27T20:17:39Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![pedro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/p/919ad9/32.png) [@pedro](https://www.ruby-forum.com/u/pedro)\
**Post date:** [June 27, 2007, 8:17pm UTC](https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952/1 "2007-06-27T20:17:39Z")

</div>

Hi all,

Sometime ago, i read the slides “when V is for Vexing: Patterns to  
DRY Up Your Views” (Bruce W. railsconf). They are not online  
anymore. I post one slide in my[1}… But only the bad smells sign in  
the view, and only problem, not the solution. here they are

1. Calling find on a model directly

2. Calling find on an association

3. Conditionally inserting content if/else clauses, case statements,  
etc

4. Doing a complex inline ma map, sor sort, t, select, etc on a  
collection

5. Assigning temporar temporary variables

I would like to ask for new bad smell signs. In the view, in the  
controller or in the model. (and discuss this , specially number 3)

Thanks

## –

Pedro Del G.

Email : removed\_email\_address@domain.invalid

---

<div class="post-metadata">

**Author:** ![pedro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/p/919ad9/32.png) [@pedro](https://www.ruby-forum.com/u/pedro)\
**Post date:** [June 27, 2007, 9:59pm UTC](https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952/2 "2007-06-27T21:59:52Z")

</div>

hmm, I’d like to see the original slides for the answers to these  
questions as well… Too bad they were taken offline…

Mike

---

<div class="post-metadata">

**Author:** ![pedro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/p/919ad9/32.png) [@pedro](https://www.ruby-forum.com/u/pedro)\
**Post date:** [June 28, 2007, 2:27am UTC](https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952/3 "2007-06-28T02:27:12Z")

</div>

Here you go 🙂  
[http://www.codefluency.com/assets/2007/5/18/VisForVexing.pdf](http://www.codefluency.com/assets/2007/5/18/VisForVexing.pdf)

---

<div class="post-metadata">

**Author:** ![pedro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/p/919ad9/32.png) [@pedro](https://www.ruby-forum.com/u/pedro)\
**Post date:** [September 25, 2007, 11:05pm UTC](https://www.ruby-forum.com/t/bad-smells-sing-in-a-rails-application/107952/4 "2007-09-25T23:05:39Z")

</div>

On 6/27/07, Brian H. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote:

> Here you go 🙂  
> [Codefluency.com](http://www.codefluency.com/assets/2007/5/18/VisForVexing.pdf)

much appreciated! Thanks!

Mike