# \[Assigned\] REXML's encoding is broken if reading UTF-16 XML and Encondig.default\_internal is set

**URL:** <https://www.ruby-forum.com/t/assigned-rexmls-encoding-is-broken-if-reading-utf-16-xml-and-encondig-default-internal-is-set/232693>\
**Category:** Development\
**Created:** [October 22, 2014, 6:09pm UTC](https://www.ruby-forum.com/t/assigned-rexmls-encoding-is-broken-if-reading-utf-16-xml-and-encondig-default-internal-is-set/232693 "2014-10-22T18:09:30Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![addis\_a](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/a/c4cdca/32.png) [@addis\_a](https://www.ruby-forum.com/u/addis_a)\
**Post date:** [October 22, 2014, 6:09pm UTC](https://www.ruby-forum.com/t/assigned-rexmls-encoding-is-broken-if-reading-utf-16-xml-and-encondig-default-internal-is-set/232693/1 "2014-10-22T18:09:30Z")

</div>

Issue #10418 has been reported by Usaku NAKAMURA.

* * *

Bug #10418: REXML’s encoding is broken if reading UTF-16 XML and  
Encondig.default\_internal is set

> **[Bug #10418: REXML's encoding is broken if reading UTF-16 XML and...](https://bugs.ruby-lang.org/issues/10418)**
>
> Redmine

- Author: Usaku NAKAMURA
- Status: Assigned
- Priority: Normal
- Assignee: Kouhei S.
- Category: lib
- Target version: current: 2.2.0
- ruby -v: -
- Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN

* * *

`Encoding.default_internal`がセットされている状態でREXMLにUTF-16なIOを食わせると、`REXML::Document#encoding`がUTF-16ではなく`Encoding.default_internal`になります。  
以下パッチ。

```auto
Index: lib/rexml/source.rb
===================================================================
--- lib/rexml/source.rb (revision 48095)
+++ lib/rexml/source.rb (working copy)
@@ -285,7 +285,7 @@
       case @encoding
       when "UTF-16BE", "UTF-16LE"
         @source.binmode
- @source.set_encoding(@encoding)
+ @source.set_encoding(@encoding, @encoding)
       end
       @line_break = encode(">")
       @pending_buffer, @buffer = @buffer, ""
Index: test/rexml/test_encoding.rb
===================================================================
--- test/rexml/test_encoding.rb (revision 48095)
+++ test/rexml/test_encoding.rb (working copy)
@@ -91,8 +91,18 @@
       utf16 = File.open(fixture_path("ticket_110_utf16.xml")) do |f|
         REXML::Document.new(f)
       end
- assert_equal(utf16.encoding, "UTF-16")
+ assert_equal("UTF-16", utf16.encoding)
       assert( utf16[0].kind_of?(REXML::XMLDecl))
     end
+
+ def test_default_internal_with_utf16
+ orig_internal = ::Encoding.default_internal
+ ::Encoding.default_internal = 'utf-8'
+ begin
+ test_ticket_110
+ ensure
+ ::Encoding.default_internal = orig_internal
+ end
+ end
   end
 end

```