Forum: Ruby case/when question

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
unknown (Guest)
on 2006-03-01 23:13
(Received via mailing list)
I was intrigued by the post that _why put up a few days/weeks ago
about using case/when for testing arrays [1]. I thought I'd give it a
try but I can't make it work. What am I doing wrong?

irb(main):001:0> r1 = (0..12).to_a
=> [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
irb(main):002:0> r2 = (20..32).to_a
=> [20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32]
irb(main):003:0> def foo range
irb(main):004:1>  case range
irb(main):005:2> when *r1
irb(main):006:2>   puts "#{range} in r1"
irb(main):007:2> when *r2
irb(main):008:2>   puts "#{range} in r2"
irb(main):009:2> else
irb(main):010:2*   puts "#{range} NOT in any range"
irb(main):011:2> end
irb(main):012:1> end
=> nil
irb(main):013:0> foo 3
NameError: undefined local variable or method `r1' for main:Object
         from (irb):5:in `foo'
         from (irb):13

This is under OSX:
ruby 1.8.4 (2005-12-24) [powerpc-darwin8.4.0]

[1] http://redhanded.hobix.com/bits/wonderOfTheWhenBeFlat.html
James G. (Guest)
on 2006-03-01 23:19
(Received via mailing list)
On Mar 1, 2006, at 3:13 PM, removed_email_address@domain.invalid wrote:

> irb(main):005:2> when *r1
>         from (irb):5:in `foo'
>         from (irb):13

Method definitions, unlike blocks, are not closures and do not have
access to local variables from the scope where they are defined.
Move the vars inside the method, or switch them to instance (or
global) vars and it will work.

Hope that helps.

James Edward G. II
unknown (Guest)
on 2006-03-01 23:21
(Received via mailing list)
On Mar 1, 2006, at 3:13 PM, removed_email_address@domain.invalid wrote:

> irb(main):005:2> when *r1
>         from (irb):5:in `foo'
>         from (irb):13

Responding to my own email...

I figured it out about 5 minutes after sending. This is purely a
scope mistake on my part. Variables r1 and r2 are NOT in scope inside
foo which is exactly what ruby told me.

The fix is to make r1 and r2 into class vars. Change r1 to @r1 and r2
to @r2 in that example and it works just fine.

Nuby making lots of mistakes!
unknown (Guest)
on 2006-03-01 23:22
(Received via mailing list)
Hi --

On Thu, 2 Mar 2006, removed_email_address@domain.invalid wrote:

> irb(main):005:2> when *r1
>       from (irb):5:in `foo'
>       from (irb):13

You've defined r1 and r2 outside of the scope of the method definition
block.  You need:

   def foo(range)
     r1 = (0..12).to_a
     r2 = .... etc

By the way you can also just use the ranges to test inclusion.



David

--
David A. Black (removed_email_address@domain.invalid)
Ruby Power and Light (http://www.rubypowerandlight.com)

"Ruby for Rails" chapters now available
from Manning Early Access Program! http://www.manning.com/books/black
unknown (Guest)
on 2006-03-01 23:26
(Received via mailing list)
Hi --

On Thu, 2 Mar 2006, removed_email_address@domain.invalid wrote:

>> => [20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32]
>> => nil
>
> The fix is to make r1 and r2 into class vars. Change r1 to @r1 and r2 to @r2
> in that example and it works just fine.

Sort of :-)  Actually @r1 is an instance variable, not a class
variable.  It's true that if you do:

   @a = 1
   def meth
     puts @a
   end
   meth

you'll get "1", but only if you are writing code at the top level of
the program.  If you do this:

   class MyClass
     @a = 1
     def meth
       puts @a
      end
    end

    MyClass.new.meth

you won't because, the two @a's are different from each other.

Class variables (@@r1) will cross the method-definition divide, but
they're somewhat cumbersome....  The best thing is to create local
variables in the scope where you need them (the method definition).


David

--
David A. Black (removed_email_address@domain.invalid)
Ruby Power and Light (http://www.rubypowerandlight.com)

"Ruby for Rails" chapters now available
from Manning Early Access Program! http://www.manning.com/books/black
This topic is locked and can not be replied to.