Forum: Ruby on Rails acts_as_taggable sql injection vulnerability

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Courtenay (Guest)
on 2005-12-16 04:05
(Received via mailing list)
Hey everyone!

If you're using acts_as_taggable <= 1.04, (erm, any version, I
think..) please fix your local copy right now!  There are numerous sql
sanitization holes in this library.

I notified Obie of this over a month ago, so hopefully he's fixed it.

How to tell lif you're vulnerable
======================
Make a tag with a single quote in it.  See if raises an error.
Now, go delete your entire database.

How to fix
========
add/change the last line of split_tag_names

tag_names = tag_names.flatten.map { |name|
  ActiveRecord::Base.connection.quote_string(tag.name.strip) }
}.uniq.compact

-- Remember to restart your app.

court3nay

http://caboo.se :: we like big fonts and yellow highlighting
http://habtm.com :: personal codelog
http://placelist.com :: just like all the cool kids
Sean S. (Guest)
on 2005-12-16 05:42
(Received via mailing list)
" http://caboo.se :: we like big fonts and yellow highlighting "

Ha!  This killed me...
This topic is locked and can not be replied to.