Issue #7936 has been reported by zzak (Zachary Scott). ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936 Author: zzak (Zachary Scott) Status: Open Priority: Normal Assignee: mame (Yusuke Endoh) Category: Target version:
on 2013-02-24 05:25
on 2013-02-24 05:48
Issue #7936 has been updated by mame (Yusuke Endoh). Status changed from Open to Assigned Assignee changed from mame (Yusuke Endoh) to nagachika (Tomoyuki Chikanaga) This is not a typo fix or format improvement, but includes (very small) semantic change. Let's consider after the patch level release after p0. -- Yusuke Endoh <mame@tsg.ne.jp> ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-36875 Author: zzak (Zachary Scott) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version:
on 2013-03-09 15:31
Issue #7936 has been updated by nagachika (Tomoyuki Chikanaga). I think passing String to these methods is meaningful because it is a way to avoid unnecessary Symbol allocation. So I'll merge r39449. mame san, do you have a concern? ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-37435 Author: zzak (Zachary Scott) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version:
on 2013-03-25 07:02
Issue #7936 has been updated by nobu (Nobuyoshi Nakada). Yes, it's meaningful, but the documents are inaccurate on that point. Any *_defined? methods don't convert the argument to a Symbol always. I don't think the distinguishment between symbol and string here is important enough. And the name _symbol_/_string_ seems less meaningful. I'd suggest to change the argument names and mention that it can be a symbole or a string. ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-37913 Author: zzak (Zachary Scott) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version:
on 2013-03-25 13:36
Issue #7936 has been updated by zzak (Zachary Scott). nobu (Nobuyoshi Nakada) wrote: > Yes, it's meaningful, but the documents are inaccurate on that point. Thank you for your feedback, always appreciated nobu-san. > I'd suggest to change the argument names and mention that it can be a symbol or a string. Do you mean for *_defined? methods or for all methods mentioned in this patch? ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-37919 Author: zzak (Zachary Scott) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version:
on 2013-04-13 19:24
Issue #7936 has been updated by nagachika (Tomoyuki Chikanaga). Status changed from Assigned to Feedback Assignee changed from nagachika (Tomoyuki Chikanaga) to nobu (Nobuyoshi Nakada) nobu, could you clarify about zzak's question? ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-38528 Author: zzak (Zachary Scott) Status: Feedback Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version:
on 2013-04-27 04:06
Issue #7936 has been updated by nobu (Nobuyoshi Nakada). I meant for all methods. Sorry for late reply. ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-38943 Author: zzak (Zachary Scott) Status: Feedback Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version:
on 2013-04-27 04:26
Issue #7936 has been updated by zzak (Zachary Scott). @nobu np, you mean something like: attr_accessor(string or symbol) or attr(string or symbol) ---------------------------------------- Backport #7936: backport r39449 https://bugs.ruby-lang.org/issues/7936#change-38945 Author: zzak (Zachary Scott) Status: Feedback Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version:
Enable email notification
Enable multi-page viewPlease log in before posting. Registration is free and takes only a minute.
Existing account
(Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
Log in with Google account | Log in with Yahoo account
No account? Register here.