Issue #7830 has been reported by kremenek (Ted Kremenek). ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-11 21:57
on 2013-02-11 23:24
Issue #7830 has been updated by kosaki (Motohiro KOSAKI). Seems very reasonable request to me. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36149 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 00:05
Issue #7830 has been updated by luislavena (Luis Lavena). kosaki (Motohiro KOSAKI) wrote: > Seems very reasonable request to me. Kosaki, who should be changing this? Shall we backport this to 2_0_0 and 1_9_3 too? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36150 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 03:28
Issue #7830 has been updated by kosaki (Motohiro KOSAKI). File disable-werror.patch added Attached RFC patch. Usa-san, Nagachika-san, I'd like propose to add --disable-werror new configure option. The intention is, trunk developer continue to use -Werror for finding a mistake as far as earlier and branch maintainers manually disable -Werror when making tar ball. Is this acceptable? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36157 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 07:38
Issue #7830 has been updated by nobu (Nobuyoshi Nakada). Your patch includes an unintentional change, -Werror-implicit-function-declaration to -Werror=implicit-function-declaration. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36159 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 07:54
> Your patch includes an unintentional change,
-Werror-implicit-function-declaration to -Werror=implicit-function-declaration.
This is intentional. -Werror=implicit-function-declaration and
-Werror-implicit-function-declaration are same meaning and there is no
reason only -Wimplicit-function-declaration keeps exceptional.
Apple made a lot of incompatibility changes in past. We can't believe
they never make the same mistake again.
on 2013-02-12 08:32
Issue #7830 has been updated by nobu (Nobuyoshi Nakada). File disable-werror.patch added It's a different story, isn't it? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36161 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 14:12
> File disable-werror.patch added > > It's a different story, isn't it? No. -Werror-implicit-function-declaration also make compilation error when compiler make new code analysis. Why do you think so?
on 2013-02-12 14:45
Issue #7830 has been updated by luislavena (Luis Lavena). kosaki (Motohiro KOSAKI) wrote: > Attached RFC patch. > > Usa-san, Nagachika-san, I'd like propose to add --disable-werror new configure option. The intention is, trunk developer continue to use -Werror > for finding a mistake as far as earlier and branch maintainers manually disable -Werror when making tar ball. Is this acceptable? Kosaki, I think the option should be the opposite. By default, -Werror should be disabled and only enabled when --enable-werror is supplied to configure script, your patch just makes this configurable, it doesn't change the default. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36173 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 16:11
Issue #7830 has been updated by mpapis (Michal Papis). The problem is only with clang, maybe we could make the flag default only for it? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36175 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-12 17:05
Issue #7830 has been updated by jonforums (Jon Forums). It might not be isolated to clang. IIRC, ~1-2 years ago the curb gem failed to build/install with mingw on windows due to -werror settings embedded in `RbConfig::CONFIG['warnflags']`. I share Luis' perspective. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36177 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 01:50
Issue #7830 has been updated by nobu (Nobuyoshi Nakada). kosaki (Motohiro KOSAKI) wrote: > No. -Werror-implicit-function-declaration also make compilation error > when compiler make new code analysis. Why do you think so? Of course it is same. Unfortunately apple-gcc still doesn't make an implicit function declaration error by -Werror= option, even if sole -Werror. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36186 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 02:44
Issue #7830 has been updated by nobu (Nobuyoshi Nakada). I found that -Werror-implicit-function-declaration has never been used. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36190 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 07:41
Issue #7830 has been updated by kremenek (Ted Kremenek). -Werror-implicit-function-declaration isn't really an issue. It is a standard warning with very clear semantics. If Ruby always builds with that warning promoted to an error that's not likely to be an issue in practice. The problem is when a new compiler (gcc, clang, or whatever) comes out with a *new* warning that is enabled by default, or changes some existing warning in a way that causes it to trigger in a way it did not before. That will cause the build to break with -Werror. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36199 Author: kremenek (Ted Kremenek) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 10:57
Issue #7830 has been updated by usa (Usaku NAKAMURA). Status changed from Closed to Assigned Assignee set to nagachika (Tomoyuki Chikanaga) I can accept current state (r39221) to backport 1.9.3. It seems to match with kosaki-san's proposal at [ruby-core:52141]. nagachika-san, how do you think about this? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36224 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 11:11
Issue #7830 has been updated by Hanmac (Hans Mackowiak). i get this with some of my gems: cc1plus: warning: command line option '-Wdeclaration-after-statement' is valid for C/ObjC but not for C++ [enabled by default] cc1plus: warning: command line option '-Wimplicit-function-declaration' is valid for C/ObjC but not for C++ [enabled by default] so do i need to take care about that or can ruby do that for me? ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36225 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 14:08
Issue #7830 has been updated by nobu (Nobuyoshi Nakada). Please file new ticket. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36228 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 15:22
Issue #7830 has been updated by nagachika (Tomoyuki Chikanaga). r39214 and r39221 seems good to me, and I think personally it could be included in 2.0.0 release. But off course mame-san has final approval for backporting to ruby_2_0_0 before release 2.0.0. mame-san, how do you think about this? If you decide not to backport them before release 2.0.0, I'll take care about this after release 2.0.0. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36234 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
on 2013-02-13 22:11
> -Werror-implicit-function-declaration isn't really an issue. It is a standard warning > with very clear semantics. If Ruby always builds with that warning promoted to an error > that's not likely to be an issue in practice. > > The problem is when a new compiler (gcc, clang, or whatever) comes out with a *new* warning > that is enabled by default, or changes some existing warning in a way that causes it to > trigger in a way it did not before. That will cause the build to break with -Werror. You don't understand current situation correctly. We didn't and never use -Werror. The problem is, we used -Werror=shorten-64-to-32 and other some specific -Werror= options and _Apple_ changed the behavior of -Werror=shorten-64-to-32. So, your comment completely make no sense.
on 2013-02-15 21:59
Issue #7830 has been updated by kremenek (Ted Kremenek). kosaki (Motohiro KOSAKI) wrote: > behavior of -Werror=shorten-64-to-32. > > So, your comment completely make no sense. I was simply responding to the comment regarding -Werror-implicit-function-declaration, which was posted before my comment. My main point was that Ruby building with *any* flag that promotes a warning to an error for source package distribution is a bad idea. No compiler warning should be treated as being stable output between compiler versions and compiler vendors. There are legitimate reasons for this: (1) Between compiler versions, the behavior of a warning may change. There may be a case that warning that was accidentally not being emitted before (a compiler bug) now gets emitted in a new version. Moreover, some new warnings may get added under an existing -W flag because that's where they belong. (2) Different compiler vendors support different warnings, or the same warnings with slightly different behavior. What may warn with one compiler may not with another, etc. For this reason, I believe that Ruby should *not* build with any of the following flags for source package distribution: -Werror -Werror-* -Werror=* Hopefully this comment makes more sense, in the broader context in which it was intended. ---------------------------------------- Bug #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-36327 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: nagachika (Tomoyuki Chikanaga) Category: Target version: ruby -v: N/A I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
[Backport93 - Backport #7830][Assigned] Ruby packages should not build with -Werror when distributed
on 2013-05-14 16:26
Issue #7830 has been updated by usa (Usaku NAKAMURA). Status changed from Closed to Assigned ---------------------------------------- Backport #7830: Ruby packages should not build with -Werror when distributed https://bugs.ruby-lang.org/issues/7830#change-39334 Author: kremenek (Ted Kremenek) Status: Assigned Priority: Normal Assignee: usa (Usaku NAKAMURA) Category: Target version: I represent the Clang compiler team at Apple, and I've heard some complaints that Clang does not work well for building Ruby. Clearly we care that Clang can compile the Ruby sources. The complaints seemed to have varied over time, but the most recent one that was reported to me seems captured by the following discussion: https://github.com/plamoni/SiriProxy/issues/436 Here the problem is that a warning is being promoted to an error via -Werror. While -Werror is a great development tool, it is not a great mechanism to enable for distributing packages as sources. Different compilers, and different versions of the same compiler, may issue different warnings, and using -Werror in source packages makes those packages very brittle to new compiler changes. With Xcode releases, we frequently enable new (or existing) warnings by default that have shown to be quite useful to finding problems. Those new warnings typically are great for development, but when coupled with -Werror and packaged sources (that aren't really changing) they can be disastrous. I do not actively build Ruby myself, but I request that Ruby software packages should not be distributed with -Werror enabled. This will greatly help users installing Ruby via homebrew or macports, and this likely will be an issue on other platforms besides OS X as well.
Enable email notification
Enable multi-page viewPlease log in before posting. Registration is free and takes only a minute.
Existing account
(Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
Log in with Google account | Log in with Yahoo account
No account? Register here.