Issue #7586 has been reported by vo.x (Vit Ondruch). ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586 Author: vo.x (Vit Ondruch) Status: Open Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-18 10:42
on 2012-12-19 08:54
Issue #7586 has been updated by nobu (Nobuyoshi Nakada). Status changed from Open to Closed It can be other than 1 if the line number is given to eval. ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586#change-34842 Author: vo.x (Vit Ondruch) Status: Closed Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-19 11:56
Issue #7586 has been updated by vo.x (Vit Ondruch). Thank you for explanation. ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586#change-34844 Author: vo.x (Vit Ondruch) Status: Closed Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-19 12:34
Issue #7586 has been updated by kosaki (Motohiro KOSAKI). I think we don't pass 1 when no line information. 0 or -1 is better. and need to be documented when such special line number is happen. ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586#change-34849 Author: vo.x (Vit Ondruch) Status: Closed Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-19 12:58
Issue #7586 has been updated by kosaki (Motohiro KOSAKI). s/don't pass/souldn't pass/ ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586#change-34851 Author: vo.x (Vit Ondruch) Status: Closed Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-19 14:07
Issue #7586 has been updated by vo.x (Vit Ondruch). kosaki (Motohiro KOSAKI) wrote: > I think we don't pass 1 when no line information. 0 or -1 is better. and need to be documented when such special line number is happen. May be it could be worth of own issue? ---------------------------------------- Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes https://bugs.ruby-lang.org/issues/7586#change-34862 Author: vo.x (Vit Ondruch) Status: Closed Priority: Normal Assignee: tenderlovemaking (Aaron Patterson) Category: Target version: ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux] I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace parse__begin(const char *, int) and parse__end(const char *, int) probes?
on 2012-12-19 14:07
Issue #7586 has been updated by vo.x (Vit Ondruch).
=begin
Just FYI, this is the output I get testing with SystemTap:
# stap -e 'probe ruby.parse.begin { printf("*** file: %s line: %d\n",
parsedfile, parsedline) }' -c 'ruby --disable-gems -e "eval \"puts
1234\", nil, \"foo\", 8"'
1234
*** file: <internal:prelude> line: 1
*** file: <internal:enc/prelude> line: 1
*** file: <internal:gem_prelude> line: 1
*** file: -e line: 1
*** file: foo line: 8
=end
----------------------------------------
Bug #7586: Useless sourceline in DTrace parse__begin and parse__end
probes
https://bugs.ruby-lang.org/issues/7586#change-34863
Author: vo.x (Vit Ondruch)
Status: Closed
Priority: Normal
Assignee: tenderlovemaking (Aaron Patterson)
Category:
Target version:
ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux]
I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at
https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does
it make sense to pass this information to DTrace parse__begin(const
char *, int) and parse__end(const char *, int) probes?
Enable email notification
Enable multi-page viewPlease log in before posting. Registration is free and takes only a minute.
Existing account
(Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
Log in with Google account | Log in with Yahoo account
No account? Register here.