Forum: Ruby-core [ruby-trunk - Bug #7585][Open] DTrace probes are inconsistent

Issue #7585 has been reported by vo.x (Vit Ondruch).

----------------------------------------
Bug #7585: DTrace probes are inconsistent
https://bugs.ruby-lang.org/issues/7585

Author: vo.x (Vit Ondruch)
Status: Open
Priority: Normal
Assignee: tenderlovemaking (Aaron Patterson)
Category:
Target version:
ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux]


These are DTrace probes available in Ruby:

process("./libruby.so").mark("find__require__entry") $arg1:long 
$arg2:long $arg3:long
process("./libruby.so").mark("find__require__return") $arg1:long 
$arg2:long $arg3:long
process("./libruby.so").mark("load__entry") $arg1:long $arg2:long 
$arg3:long
process("./libruby.so").mark("load__return") $arg1:long
process("./libruby.so").mark("require__entry") $arg1:long $arg2:long 
$arg3:long
process("./libruby.so").mark("require__return") $arg1:long

I am wondering, why find__require__return probe accepts more parameters 
then the load__return and require__return. They should all accept the 
same parameters IMO. No matter if they provide the source informations 
or not.

Also the remaining pair probes should be probably revisited and made 
consistent with the probes above:

process("./libruby.so").mark("cmethod__entry") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("cmethod__return") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("method__entry") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("method__return") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("parse__begin") $arg1:long $arg2:long
process("./libruby.so").mark("parse__end") $arg1:long $arg2:long

Issue #7585 has been updated by usa (Usaku NAKAMURA).

Status changed from Open to Assigned


----------------------------------------
Bug #7585: DTrace probes are inconsistent
https://bugs.ruby-lang.org/issues/7585#change-34958

Author: vo.x (Vit Ondruch)
Status: Assigned
Priority: Normal
Assignee: tenderlovemaking (Aaron Patterson)
Category:
Target version:
ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux]


These are DTrace probes available in Ruby:

process("./libruby.so").mark("find__require__entry") $arg1:long 
$arg2:long $arg3:long
process("./libruby.so").mark("find__require__return") $arg1:long 
$arg2:long $arg3:long
process("./libruby.so").mark("load__entry") $arg1:long $arg2:long 
$arg3:long
process("./libruby.so").mark("load__return") $arg1:long
process("./libruby.so").mark("require__entry") $arg1:long $arg2:long 
$arg3:long
process("./libruby.so").mark("require__return") $arg1:long

I am wondering, why find__require__return probe accepts more parameters 
then the load__return and require__return. They should all accept the 
same parameters IMO. No matter if they provide the source informations 
or not.

Also the remaining pair probes should be probably revisited and made 
consistent with the probes above:

process("./libruby.so").mark("cmethod__entry") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("cmethod__return") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("method__entry") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("method__return") $arg1:long $arg2:long 
$arg3:long $arg4:long
process("./libruby.so").mark("parse__begin") $arg1:long $arg2:long
process("./libruby.so").mark("parse__end") $arg1:long $arg2:long