Forum: Ruby-core [ruby-trunk - Bug #7563][Assigned] test of gem_ext_cmake_builder in another directory

Issue #7563 has been reported by tarui (Masaya Tarui).

----------------------------------------
Bug #7563: test of gem_ext_cmake_builder in another directory
https://bugs.ruby-lang.org/issues/7563

Author: tarui (Masaya Tarui)
Status: Assigned
Priority: Low
Assignee: drbrain (Eric Hodel)
Category:
Target version: 2.0.0
ruby -v: ruby 2.0.0dev (2012-12-14 trunk 38369) [x86_64-linux]


would you commit it? or can I ?

Index: test/rubygems/test_gem_ext_cmake_builder.rb
===================================================================
--- test/rubygems/test_gem_ext_cmake_builder.rb (revision 38369)
+++ test/rubygems/test_gem_ext_cmake_builder.rb (working copy)
@@ -36,7 +36,7 @@
     assert_equal "cmake . -DCMAKE_INSTALL_PREFIX=#{@dest_path}", 
output.shift
     assert_match(/#{@ext}/, output.shift)
     assert_equal make_command, output.shift
-    assert_equal "", output.shift
+    assert_equal "", output.shift.gsub(/^make\[1\]: 
(?:Entering|Leaving) directory .*\n/,"")
     assert_equal make_command + " install", output.shift
     assert_match(/test\.txt/, output.shift)
   end

Issue #7563 has been updated by drbrain (Eric Hodel).

Category set to lib
Assignee changed from drbrain (Eric Hodel) to tarui (Masaya Tarui)

Please commit it, I will apply it to RubyGems.

I guess I didn't catch it because I build from $(srcdir)/../build?
----------------------------------------
Bug #7563: test of gem_ext_cmake_builder in another directory
https://bugs.ruby-lang.org/issues/7563#change-34754

Author: tarui (Masaya Tarui)
Status: Assigned
Priority: Low
Assignee: tarui (Masaya Tarui)
Category: lib
Target version: 2.0.0
ruby -v: ruby 2.0.0dev (2012-12-14 trunk 38369) [x86_64-linux]


would you commit it? or can I ?

Index: test/rubygems/test_gem_ext_cmake_builder.rb
===================================================================
--- test/rubygems/test_gem_ext_cmake_builder.rb (revision 38369)
+++ test/rubygems/test_gem_ext_cmake_builder.rb (working copy)
@@ -36,7 +36,7 @@
     assert_equal "cmake . -DCMAKE_INSTALL_PREFIX=#{@dest_path}", 
output.shift
     assert_match(/#{@ext}/, output.shift)
     assert_equal make_command, output.shift
-    assert_equal "", output.shift
+    assert_equal "", output.shift.gsub(/^make\[1\]: 
(?:Entering|Leaving) directory .*\n/,"")
     assert_equal make_command + " install", output.shift
     assert_match(/test\.txt/, output.shift)
   end

Issue #7563 has been updated by tarui (Masaya Tarui).

Status changed from Assigned to Closed

I committed it at r38390.

----------------------------------------
Bug #7563: test of gem_ext_cmake_builder in another directory
https://bugs.ruby-lang.org/issues/7563#change-34755

Author: tarui (Masaya Tarui)
Status: Closed
Priority: Low
Assignee: tarui (Masaya Tarui)
Category: lib
Target version: 2.0.0
ruby -v: ruby 2.0.0dev (2012-12-14 trunk 38369) [x86_64-linux]


would you commit it? or can I ?

Index: test/rubygems/test_gem_ext_cmake_builder.rb
===================================================================
--- test/rubygems/test_gem_ext_cmake_builder.rb (revision 38369)
+++ test/rubygems/test_gem_ext_cmake_builder.rb (working copy)
@@ -36,7 +36,7 @@
     assert_equal "cmake . -DCMAKE_INSTALL_PREFIX=#{@dest_path}", 
output.shift
     assert_match(/#{@ext}/, output.shift)
     assert_equal make_command, output.shift
-    assert_equal "", output.shift
+    assert_equal "", output.shift.gsub(/^make\[1\]: 
(?:Entering|Leaving) directory .*\n/,"")
     assert_equal make_command + " install", output.shift
     assert_match(/test\.txt/, output.shift)
   end