Forum: Ruby-core Becoming a committer

Hi ruby-core,

I'd like to become a committer to Ruby. I've had a few patches accepted 
and I'd like to step up and continue contributing on greater level.

Cheers,

Charlie

Hi,

OK, send your pgp signed ssh2 public key to cvs-admin@ruby-lang.org
with your sought account name.  Besides that, may I ask you what you
have in mind to contribute?

              matz.

In message "Re: [ruby-core:50755] Becoming a committer"
    on Tue, 11 Dec 2012 22:14:43 +0900, Charlie Somerville 
<charlie@charliesomerville.com> writes:

|Hi ruby-core,
|
|I'd like to become a committer to Ruby. I've had a few patches accepted and I'd 
like to step up and continue contributing on greater level.
|
|Cheers,
|
|Charlie

Thanks!

I plan on working on trawling Redmine and working on bugs - I understand 
the existing developers are very busy so I thought some extra help would 
be appreciated.

It's really this easy? If so, I'll send over my public key today :)

- Charlie

While I'm not part of the Ruby core team I'd personally would like to
see a slightly more convincing reason. What exactly is it that you aim
to solve besides just fixing bugs? The latter can be done without commit
access using the Github fork and I'm sure there are other ways as well.

Don't get me wrong, the more people help team matz the better but in my
opinion being a member of the Ruby team comes with quite a few
responsibilities that are not as easy as they initially might seem.

To cut a long story short: I'm interested in a more in depth explanation
instead of "I will fix bugs".

Yorick

Yeah, it surprised me a bit too knowing
https://bugs.ruby-lang.org/projects/ruby/wiki/Comm...,
but of course this is matz's decision and I respect it. I think ideally
it's better to not ask for commit rights.

On Tue, Dec 11, 2012 at 8:55 PM, Charles Oliver Nutter
<headius@headius.com> wrote:
> It's really this easy? If so, I'll send over my public key today :)
>
> - Charlie

It's always easier being the first (to ask) ;-)

Hi,

In message "Re: [ruby-core:50784] Re: Becoming a committer"
    on Wed, 12 Dec 2012 04:55:00 +0900, Charles Oliver Nutter 
<headius@headius.com> writes:

|It's really this easy? If so, I'll send over my public key today :)
|
|- Charlie

You didn't know, did you?  And what have you in mind?

              matz.

I guess there's a few things I'd be interested in:

* Cleaning up tests in preparation for process updates and filling out 
RubySpec.
* Stdlib performance investigation, based on current Ruby impl 
capabilities
* Synchronization of JRuby and MRI stdlib (fixes in one or other,
improvements and rewrites, ...)
* Stdlib gemification

Mostly leaning toward getting .rb sources (stdlib, tests) in better
shape across impls and separating spec tests from MRI-specific tests.

- Charlie

2012/12/12 Yorick Peterse <yorickpeterse@gmail.com>:
> While I'm not part of the Ruby core team I'd personally would like to
> see a slightly more convincing reason. What exactly is it that you aim
> to solve besides just fixing bugs? The latter can be done without commit
> access using the Github fork and I'm sure there are other ways as well.

If a person fixes many bugs, he/she must write many tickets and 
committers
must review and merge them.
It is troublesome.
So we sometimes invite people who contribute many bug fixes as a 
committer.

> Don't get me wrong, the more people help team matz the better but in my
> opinion being a member of the Ruby team comes with quite a few
> responsibilities that are not as easy as they initially might seem.

Don't worry.
If a commit breaks ruby, I'll revert it.
You can also report such buggy commits.

Hi,

You can send us your key.

              matz.

In message "Re: [ruby-core:50797] Re: Becoming a committer"
    on Wed, 12 Dec 2012 08:55:50 +0900, Charles Oliver Nutter 
<headius@headius.com> writes:
|
|I guess there's a few things I'd be interested in:
|
|* Cleaning up tests in preparation for process updates and filling out RubySpec.
|* Stdlib performance investigation, based on current Ruby impl capabilities
|* Synchronization of JRuby and MRI stdlib (fixes in one or other,
|improvements and rewrites, ...)
|* Stdlib gemification
|
|Mostly leaning toward getting .rb sources (stdlib, tests) in better
|shape across impls and separating spec tests from MRI-specific tests.
|
|- Charlie

(2012/12/12 8:55), Charles Oliver Nutter wrote:
> * Synchronization of JRuby and MRI stdlib (fixes in one or other,
> improvements and rewrites, ...)

Maybe you want make them thread-safe.
I'm not sure they can be done in acceptable performance.
(MRI's sync overhead is bad compare with JVM's sync)

On Wed, Dec 12, 2012 at 12:04 AM, SASADA Koichi <ko1@atdot.net> wrote:
> (2012/12/12 8:55), Charles Oliver Nutter wrote:
>> * Synchronization of JRuby and MRI stdlib (fixes in one or other,
>> improvements and rewrites, ...)
>
> Maybe you want make them thread-safe.
> I'm not sure they can be done in acceptable performance.
> (MRI's sync overhead is bad compare with JVM's sync)

I meant reducing the diffs between JRuby and MRI's copies of stdlib as
much as possible. There's not many, but a few libs we've completely
replaced. They're good changes, I think.

Thread-safety is another good goal I'd love to look into, but it's not
a zero-sum task.

- Charlie

2012/12/12 Charles Oliver Nutter <headius@headius.com>:
> much as possible. There's not many, but a few libs we've completely
> replaced. They're good changes, I think.

headius contributed some patches for tests and libs before.
So if headius has commit bit, it will be useful.

On Wed, Dec 12, 2012 at 2:59 AM, NARUSE, Yui <naruse@airemix.jp> wrote:
> headius contributed some patches for tests and libs before.
> So if headius has commit bit, it will be useful.

I appreciate the vote of confidence!

I have sent my information!

- Charlie

(2012/12/12 17:38), Charles Oliver Nutter wrote:
> I meant reducing the diffs between JRuby and MRI's copies of stdlib as
> much as possible. There's not many, but a few libs we've completely
> replaced. They're good changes, I think.
>
> Thread-safety is another good goal I'd love to look into, but it's not
> a zero-sum task.

Ah, I misunderstood the word "Synchronization"!!
Sorry.

On Dec 12, 2012 4:00 AM, "NARUSE, Yui" <naruse@airemix.jp> wrote:
>
> headius contributed some patches for tests and libs before.
> So if headius has commit bit, it will be useful.
>

I agree, more direct contributions by Charles Oliver Nutter will be much
appreciated.

Matz, can I create his SVN account?

2012/12/12 Charles Oliver Nutter <headius@headius.com>:

Hi,

In message "Re: [ruby-core:50844] Re: Becoming a committer"
    on Thu, 13 Dec 2012 07:17:08 +0900, Shugo Maeda 
<shugo@ruby-lang.org> writes:

|Matz, can I create his SVN account?

Yes!

              matz.

Hi,

2012/12/13 Yukihiro Matsumoto <matz@ruby.or.jp>:
> |Matz, can I create his SVN account?
>
> Yes!

Done!

On Wed, Dec 12, 2012 at 6:07 PM, Shugo Maeda <shugo@ruby-lang.org> 
wrote:
> 2012/12/13 Yukihiro Matsumoto <matz@ruby.or.jp>:
>> |Matz, can I create his SVN account?
>>
>> Yes!
>
> Done!

Thank you! I will try to be a productive member of ruby-core :)

- Charlie