Forum: Ruby-core [ruby-trunk - Feature #7400][Open] Incorporate OpenSSL tests from JRuby.

Issue #7400 has been reported by zzak (Zachary Scott).

----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400

Author: zzak (Zachary Scott)
Status: Open
Priority: Normal
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.0.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by MartinBosslet (Martin Bosslet).


zzak (Zachary Scott) wrote:
> =begin
> from github: https://github.com/ruby/ruby/pull/206
>
> ((*These are tests we added to jruby-openssl over the years. They did not have 
equivalents in Ruby's test suite, so we are hoping to contribute them back to help 
build up MRI's suite as a common suite.*))

Thank you, I really like and appreciate the idea.

> ((*Some caveats:*))
>
> * ((*Not all of these pass in MRI's OpenSSL impl. Many differences appear to be 
minor, but I need help sorting out what's wrong in MRI or JRuby or minor enough 
that the test just needs to be patched.*))

OK, I will run the tests on my machine and publish the report here. We 
could discuss our next actions based on the results then?

> * ((*There are several tests that reference bug numbers from JRuby. We would 
like to contribute these tests, but we would ideally not lose the JRuby bug 
numbers for future reference.*))

I'm confused, I was thinking I could simply strip those references when 
committing it to CRuby, or not?

> * ((*This commit also adds fixtures for the certificate tests, using some 
self-generated certs, keys, etc.*))

Hmm, it might be worth the effort trying to combine what we have in an 
attempt to refactor and clean up. There's already similar stuff in our 
test suite, my bet is there will probably be some redundancies. I'd be 
happy to work with you to clean this up!

> ((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))

Again, thanks for your efforts!


----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-33368

Author: zzak (Zachary Scott)
Status: Open
Priority: Normal
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.0.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by mame (Yusuke Endoh).

Status changed from Open to Assigned

Adding tests is always welcome.  Thank you!

Martin, you can commit it even after preview2 release if it contains 
only tests.
(Of course, it is much better to include it in preview2.)
But, note that any expected failure should not be left; it will make the 
rubyci result difficult to see.

--
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-33747

Author: zzak (Zachary Scott)
Status: Assigned
Priority: Normal
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.0.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by mame (Yusuke Endoh).

Priority changed from Normal to Low

Let me set the priority to low to distinguish other 2.0.0 mandatory 
tickets.

--
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-33770

Author: zzak (Zachary Scott)
Status: Assigned
Priority: Low
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.0.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by headius (Charles Nutter).


MartinBosslet (Martin Bosslet) wrote:
> > ((*Some caveats:*))
> >
> > * ((*Not all of these pass in MRI's OpenSSL impl. Many differences appear to 
be minor, but I need help sorting out what's wrong in MRI or JRuby or minor enough 
that the test just needs to be patched.*))
>
> OK, I will run the tests on my machine and publish the report here. We could 
discuss our next actions based on the results then?

Sounds good. I will monitor this bug, but poke me if I haven't noticed 
updates.

> > * ((*There are several tests that reference bug numbers from JRuby. We would 
like to contribute these tests, but we would ideally not lose the JRuby bug 
numbers for future reference.*))
>
> I'm confused, I was thinking I could simply strip those references when 
committing it to CRuby, or not?

I guess there's no good way to keep JRuby bug information present in 
those issues. Can we at least make sure the essence of the bug's 
description is captured in a one-line comment for those tests? It would 
be nice to see more comments in MRI tests indicating what they're 
testing in natural language.

> > * ((*This commit also adds fixtures for the certificate tests, using some 
self-generated certs, keys, etc.*))
>
> Hmm, it might be worth the effort trying to combine what we have in an attempt 
to refactor and clean up. There's already similar stuff in our test suite, my bet 
is there will probably be some redundancies. I'd be happy to work with you to 
clean this up!

That sounds just fine. I think we added stuff, MRI added stuff, and now 
merging together requires a little cleanup. I'm just not a crypto guy so 
I will have trouble determining which tests are redundant.

As far as cert/key fixtures go, there's very few tests that wouldn't 
work with any old cert or key...so that's worth cleaning up for sure.

As a subsequent step, it would be worthwhile to port some of these tests 
(with additional cleanup) into RubySpec.
----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-33864

Author: zzak (Zachary Scott)
Status: Assigned
Priority: Low
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.0.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by ko1 (Koichi Sasada).

Target version changed from 2.0.0 to 2.1.0

ping -> Martin
----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-36915

Author: zzak (Zachary Scott)
Status: Assigned
Priority: Low
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.1.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end

Issue #7400 has been updated by MartinBosslet (Martin Bosslet).


I'm sorry I couldn't make this happen in time for 2.0.0. I will try to 
sync with the JRuby devs to unify the tests for 2.1.0.
----------------------------------------
Feature #7400: Incorporate OpenSSL tests from JRuby.
https://bugs.ruby-lang.org/issues/7400#change-36971

Author: zzak (Zachary Scott)
Status: Assigned
Priority: Low
Assignee: MartinBosslet (Martin Bosslet)
Category: ext
Target version: 2.1.0


=begin
from github: https://github.com/ruby/ruby/pull/206

((*These are tests we added to jruby-openssl over the years. They did 
not have equivalents in Ruby's test suite, so we are hoping to 
contribute them back to help build up MRI's suite as a common suite.*))

((*Some caveats:*))

* ((*Not all of these pass in MRI's OpenSSL impl. Many differences 
appear to be minor, but I need help sorting out what's wrong in MRI or 
JRuby or minor enough that the test just needs to be patched.*))
* ((*There are several tests that reference bug numbers from JRuby. We 
would like to contribute these tests, but we would ideally not lose the 
JRuby bug numbers for future reference.*))
* ((*This commit also adds fixtures for the certificate tests, using 
some self-generated certs, keys, etc.*))

((*I am standing by to work with ruby-core on getting these tests 
incorporated.*))
=end