Forum: Ruby-core [ruby-trunk - Feature #7387][Open] Keep LOADED_FEATURES sorted by filename without extention for fas

Posted by zzak (Zachary Scott) (Guest)
on 2012-11-18 23:33
(Received via mailing list)
Issue #7387 has been reported by zzak (Zachary Scott).

----------------------------------------
Feature #7387: Keep LOADED_FEATURES sorted by filename without extention 
for faster lookup on require.
https://bugs.ruby-lang.org/issues/7387

Author: zzak (Zachary Scott)
Status: Open
Priority: Normal
Assignee: mame (Yusuke Endoh)
Category: core
Target version: 2.0.0


I'm moving this over from github:
https://github.com/ruby/ruby/pull/66
Posted by mame (Yusuke Endoh) (Guest)
on 2012-11-19 19:09
(Received via mailing list)
Issue #7387 has been updated by mame (Yusuke Endoh).

Status changed from Open to Feedback
Assignee changed from mame (Yusuke Endoh) to zzak (Zachary Scott)

Zachary, thank you for the sorting out the tickets!

I think that the problem itself was fixed effectively by #7158.
Am I misunderstanding?

--
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Feature #7387: Keep LOADED_FEATURES sorted by filename without extention 
for faster lookup on require.
https://bugs.ruby-lang.org/issues/7387#change-33113

Author: zzak (Zachary Scott)
Status: Feedback
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: core
Target version: 2.0.0


I'm moving this over from github:
https://github.com/ruby/ruby/pull/66
Posted by zzak (Zachary Scott) (Guest)
on 2012-11-19 19:14
(Received via mailing list)
Issue #7387 has been updated by zzak (Zachary Scott).


mame, you're welcome, I hope it helps you with the release!

I wasn't sure if this was included in #7158, so it may be duplicate. 
Feel free to close this ticket.
----------------------------------------
Feature #7387: Keep LOADED_FEATURES sorted by filename without extention 
for faster lookup on require.
https://bugs.ruby-lang.org/issues/7387#change-33116

Author: zzak (Zachary Scott)
Status: Feedback
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: core
Target version: 2.0.0


I'm moving this over from github:
https://github.com/ruby/ruby/pull/66
Posted by zzak (Zachary Scott) (Guest)
on 2012-11-19 19:15
(Received via mailing list)
Issue #7387 has been updated by zzak (Zachary Scott).

Assignee changed from zzak (Zachary Scott) to h.shirosaki (Hiroshi 
Shirosaki)

Hiroshi-san can you verify this has been resolved?
----------------------------------------
Feature #7387: Keep LOADED_FEATURES sorted by filename without extention 
for faster lookup on require.
https://bugs.ruby-lang.org/issues/7387#change-33119

Author: zzak (Zachary Scott)
Status: Feedback
Priority: Normal
Assignee: h.shirosaki (Hiroshi Shirosaki)
Category: core
Target version: 2.0.0


I'm moving this over from github:
https://github.com/ruby/ruby/pull/66
Posted by h.shirosaki (Hiroshi Shirosaki) (Guest)
on 2012-11-19 23:13
(Received via mailing list)
Issue #7387 has been updated by h.shirosaki (Hiroshi Shirosaki).

Status changed from Feedback to Closed

LOADED_FEATURES hash index was included in #7158. Sorted LOADED_FEATURES 
is another approach for faster LOADED_FEATURES lookup in require, but we 
cannot apply both of them since they are conflicted implementations. 
Performance issue of require was fixed by #7158. So I close this.
----------------------------------------
Feature #7387: Keep LOADED_FEATURES sorted by filename without extention 
for faster lookup on require.
https://bugs.ruby-lang.org/issues/7387#change-33131

Author: zzak (Zachary Scott)
Status: Closed
Priority: Normal
Assignee: h.shirosaki (Hiroshi Shirosaki)
Category: core
Target version: 2.0.0


I'm moving this over from github:
https://github.com/ruby/ruby/pull/66
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.