Forum: Ruby-dev [ruby-trunk - Bug #7111][Open] New build option to enable/disable global method caching

Posted by shugo (Shugo Maeda) (Guest)
on 2012-10-06 04:19
(Received via mailing list)
Issue #7111 has been reported by shugo (Shugo Maeda).

----------------------------------------
Bug #7111: New build option to enable/disable global method caching
https://bugs.ruby-lang.org/issues/7111

Author: shugo (Shugo Maeda)
Status: Open
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]


Ruby has a build option to enable/disable inline method caching 
(OPT_INLINE_METHOD_CACHE), but has no such option for global method 
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I've attached a patch to add that option.
Posted by SASADA Koichi (Guest)
on 2012-10-06 05:03
(Received via mailing list)
(2012/10/06 11:19), shugo (Shugo Maeda) wrote:
> Ruby has a build option to enable/disable inline method caching 
(OPT_INLINE_METHOD_CACHE), but has no such option for global method caching.
> How about to add a new build option OPT_GLOBAL_METHOD_CACHE?
>
> I've attached a patch to add that option.

I don't have any objection.
Where is a patch?
Posted by shugo (Shugo Maeda) (Guest)
on 2012-10-06 08:32
(Received via mailing list)
Issue #7111 has been updated by shugo (Shugo Maeda).

File opt_global_method_cache.diff added

ko1 (Koichi Sasada) wrote:
>  I don't have any objection.
>  Where is a patch?

I forgot to attach it:(
Please see opt_global_method_cache.diff attached.
----------------------------------------
Bug #7111: New build option to enable/disable global method caching
https://bugs.ruby-lang.org/issues/7111#change-30116

Author: shugo (Shugo Maeda)
Status: Open
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]


Ruby has a build option to enable/disable inline method caching 
(OPT_INLINE_METHOD_CACHE), but has no such option for global method 
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I've attached a patch to add that option.
Posted by SASADA Koichi (Guest)
on 2012-10-06 10:20
(Received via mailing list)
(2012/10/06 15:31), shugo (Shugo Maeda) wrote:
> I forgot to attach it:(
> Please see opt_global_method_cache.diff attached.

It is okay.  But I recommend that only method search at the the
`rb_method_entry_get_with_omod' should be disable to measure and compare
performance.
Posted by shugo (Shugo Maeda) (Guest)
on 2012-10-06 11:37
(Received via mailing list)
Issue #7111 has been updated by shugo (Shugo Maeda).


ko1 (Koichi Sasada) wrote:
> (2012/10/06 15:31), shugo (Shugo Maeda) wrote:
>  > I forgot to attach it:(
>  > Please see opt_global_method_cache.diff attached.
>
>  It is okay.  But I recommend that only method search at the the
>  `rb_method_entry_get_with_omod' should be disable to measure and compare
>  performance.

I've committed the fix with the above change.
----------------------------------------
Bug #7111: New build option to enable/disable global method caching
https://bugs.ruby-lang.org/issues/7111#change-30121

Author: shugo (Shugo Maeda)
Status: Closed
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]


Ruby has a build option to enable/disable inline method caching 
(OPT_INLINE_METHOD_CACHE), but has no such option for global method 
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I've attached a patch to add that option.
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.