Forum: Ruby-core [ruby-trunk - Bug #6750][Open] Comment above rb_iseq_struct.local_size gives out of date description

Issue #6750 has been reported by davidbalbert (David Albert).

----------------------------------------
Bug #6750: Comment above rb_iseq_struct.local_size gives out of date 
description
https://bugs.ruby-lang.org/issues/6750

Author: davidbalbert (David Albert)
Status: Open
Priority: Normal
Assignee:
Category:
Target version:
ruby -v: 2.0.0dev


The description of rb_iseq_struct.local_size says that it is 
sizeof(local vars) + 1 for class and method frames, but just 
sizeof(local vars) for block frames. I think this is no longer the case. 
local_size is always sizeof(local vars) + 1.

Here's the relevant code from when the comment was written (2007): 
https://github.com/ruby/ruby/blob/71986ef6bc232455...
And here's the code today: 
https://github.com/ruby/ruby/blob/trunk/compile.c#L5571

I've attached a patch that fixes the comment.

Issue #6750 has been updated by mame (Yusuke Endoh).

Status changed from Open to Assigned
Assignee set to ko1 (Koichi Sasada)

Thank you.  Ko1, do you apply his patch?  It is clearly benign.

--
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Bug #6750: Comment above rb_iseq_struct.local_size gives out of date 
description
https://bugs.ruby-lang.org/issues/6750#change-32268

Author: davidbalbert (David Albert)
Status: Assigned
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category:
Target version:
ruby -v: 2.0.0dev


The description of rb_iseq_struct.local_size says that it is 
sizeof(local vars) + 1 for class and method frames, but just 
sizeof(local vars) for block frames. I think this is no longer the case. 
local_size is always sizeof(local vars) + 1.

Here's the relevant code from when the comment was written (2007): 
https://github.com/ruby/ruby/blob/71986ef6bc232455...
And here's the code today: 
https://github.com/ruby/ruby/blob/trunk/compile.c#L5571

I've attached a patch that fixes the comment.

Issue #6750 has been updated by ko1 (Koichi Sasada).


I'm sorry I missed this issue (because no "target version". sorry 
again).
I applied it.

Thanks!
----------------------------------------
Bug #6750: Comment above rb_iseq_struct.local_size gives out of date 
description
https://bugs.ruby-lang.org/issues/6750#change-35590

Author: davidbalbert (David Albert)
Status: Closed
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category:
Target version:
ruby -v: 2.0.0dev


The description of rb_iseq_struct.local_size says that it is 
sizeof(local vars) + 1 for class and method frames, but just 
sizeof(local vars) for block frames. I think this is no longer the case. 
local_size is always sizeof(local vars) + 1.

Here's the relevant code from when the comment was written (2007): 
https://github.com/ruby/ruby/blob/71986ef6bc232455...
And here's the code today: 
https://github.com/ruby/ruby/blob/trunk/compile.c#L5571

I've attached a patch that fixes the comment.