Issue #6504 has been reported by hansdegraaff (Hans de Graaff). ---------------------------------------- Bug #6504: mkrf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504 Author: hansdegraaff (Hans de Graaff) Status: Open Priority: Normal Assignee: Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2012-05-27 11:31
on 2012-05-27 12:21
Issue #6504 has been updated by mame (Yusuke Endoh). Status changed from Open to Assigned Assignee set to nobu (Nobuyoshi Nakada) ---------------------------------------- Bug #6504: mkrf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-26852 Author: hansdegraaff (Hans de Graaff) Status: Assigned Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2012-05-28 04:35
Issue #6504 has been updated by nobu (Nobuyoshi Nakada). Status changed from Assigned to Feedback hansdegraaff (Hans de Graaff) wrote: > For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281 I can't see that page because of "untrusted issuer error". ---------------------------------------- Bug #6504: mkrf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-26866 Author: hansdegraaff (Hans de Graaff) Status: Feedback Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2013-01-25 23:05
Issue #6504 has been updated by drbrain (Eric Hodel). Subject changed from mkrf.rb should not use CFLAGS when compiling C++ code to mkmf.rb should not use CFLAGS when compiling C++ code Status changed from Feedback to Rejected Since the submitter has not given access to the downstream bug report as requested I am rejecting this. ---------------------------------------- Bug #6504: mkmf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-35656 Author: hansdegraaff (Hans de Graaff) Status: Rejected Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2013-03-28 23:52
Issue #6504 has been updated by postmodern (Hal Brodigan). Visiting https://bugs.gentoo.org/ gives me "Error code: sec_error_untrusted_issuer)" with Firefox 19 on Fedora 17. I can however add an exception and temporarily trust the certificate in order to view the bug report. ---------------------------------------- Bug #6504: mkmf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-38016 Author: hansdegraaff (Hans de Graaff) Status: Rejected Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2013-03-29 00:33
Issue #6504 has been updated by Flameeyes (Diego E. Pettenò). It's not like the bug at Gentoo adds much more. It just happens to be somebody who has different CFLAGS/CXXFLAGS (like many do, for instance it's common to use -ggdb3 on C code, but not enabling it on C++ code because it requires at least an order of magnitude more ram), and gets fxruby built with the wrong set. How much more info than this (which was provided in the original report, including the reference to the line where the mix-up is happening) do you expect? An essay on why you should not mix flags for one language with those for another? A dissertation on why any half-serious build system, including both Autotools and CMake, keep the two separate? ---------------------------------------- Bug #6504: mkmf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-38018 Author: hansdegraaff (Hans de Graaff) Status: Rejected Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
on 2013-03-29 01:03
Issue #6504 has been updated by drbrain (Eric Hodel). Status changed from Rejected to Assigned ---------------------------------------- Bug #6504: mkmf.rb should not use CFLAGS when compiling C++ code https://bugs.ruby-lang.org/issues/6504#change-38019 Author: hansdegraaff (Hans de Graaff) Status: Assigned Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable. https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786 CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']} For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281
Enable email notification
Enable multi-page viewPlease log in before posting. Registration is free and takes only a minute.
Existing account
(Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
Log in with Google account | Log in with Yahoo account
No account? Register here.