Issue #6482 has been reported by drbrain (Eric Hodel). ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482 Author: drbrain (Eric Hodel) Status: Open Priority: Normal Assignee: Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-05-23 04:48
on 2012-05-23 04:49
Issue #6482 has been updated by drbrain (Eric Hodel). File net.http.request_response_uri.patch added Forgot patch ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-26777 Author: drbrain (Eric Hodel) Status: Open Priority: Normal Assignee: Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-05-26 18:08
Issue #6482 has been updated by mame (Yusuke Endoh). Hello, drbrain Are you willing to be a net/http(s) maintainer? I think you deserve it. Matz, do you accept him if he is willing? -- Yusuke Endoh <mame@tsg.ne.jp> ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-26848 Author: drbrain (Eric Hodel) Status: Open Priority: Normal Assignee: Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-05-28 13:37
2012/5/27 mame (Yusuke Endoh) <mame@tsg.ne.jp>: > > Issue #6482 has been updated by mame (Yusuke Endoh). > > > Hello, drbrain > > Are you willing to be a net/http(s) maintainer? > I think you deserve it. > > Matz, do you accept him if he is willing? You seem forget [ruby-core:43912].
on 2012-05-28 13:44
Oops, sorry. Please update the maintainer list of redmine wiki. 2012/5/28 NARUSE, Yui <naruse@airemix.jp>:
on 2012-05-29 23:08
On May 28, 2012, at 04:37, NARUSE, Yui wrote: >> Matz, do you accept him if he is willing? > > You seem forget [ruby-core:43912]. I prefer submitting patches that NARUSE Yui reviews for me. I am glad Yui is net/http maintainer.
on 2012-05-31 16:11
Issue #6482 has been updated by mame (Yusuke Endoh). Status changed from Open to Assigned Assignee set to naruse (Yui NARUSE) ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-26916 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-06-06 21:36
Issue #6482 has been updated by naruse (Yui NARUSE). I'm still considering this, but current thought is The direction of this seems correct. On HTTP/1.1 requires Host field in the header. This is just needed by persistence connection. When you connect a server and communicate two or more hosts on the server with one connection, the Host information must be retrieved from each request, and each response should have its own uri. This means all request/response should have its own URI information. So current patch's return the given URI seems not ideal. ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-27043 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-06-07 03:02
Issue #6482 has been updated by drbrain (Eric Hodel). File net.http.request_response_uri.2.patch added naruse (Yui NARUSE) wrote: > I'm still considering this, but current thought is > > The direction of this seems correct. > On HTTP/1.1 requires Host field in the header. > > This is just needed by persistence connection. > When you connect a server and communicate two or more hosts on the server with one connection, > the Host information must be retrieved from each request, I have updated the patch to obey the Host header when setting the URI, and to set the Host header from the URI when creating the request (unless overridden by initheader). > and each response should have its own uri. > > This means all request/response should have its own URI information. > So current patch's return the given URI seems not ideal. Each response has a separate URI instance from the request due to use of dup. I've added extra assertions in test_http.rb to the revised patch to cover this. By "all request/response should have its own URI information" do you mean "The request URI should not be edited"? This does not seem to match the current behavior of req['Host'] as it must be manually cleared in order to reuse the request with a different host. What should this output: require 'net/http' uri = URI 'http://example/' req = Net::HTTP::Get.new uri res = Net::HTTP.start 'other.example' do |http| http.request req end puts "req URI: #{req.uri}" puts "req Host: #{req['Host']}" With the updated patch, req.uri is http://example With my original patch, req.uri is http://other.example Unpatched, net/http shows "other.example" for the Host, "example" with the latest patch. ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-27051 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-06-08 17:19
Issue #6482 has been updated by naruse (Yui NARUSE). drbrain (Eric Hodel) wrote: > naruse (Yui NARUSE) wrote: > > and each response should have its own uri. > > > > This means all request/response should have its own URI information. > > So current patch's return the given URI seems not ideal. > > Each response has a separate URI instance from the request due to use of dup. I've added extra assertions in test_http.rb to the revised patch to cover this. > > By "all request/response should have its own URI information" do you mean "The request URI should not be edited"? No for scheme and port. > This does not seem to match the current behavior of req['Host'] as it must be manually cleared in order to reuse the request with a different host. Try following: require 'net/http' req = Net::HTTP::Get.new '/' puts "req Host: #{req['Host']}" res = Net::HTTP.start 'redmine.ruby-lang.org' do |http| http.request req end puts "req Host: #{req['Host']}" res = Net::HTTP.start 'bugs.ruby-lang.org' do |http| http.request req end puts "req Host: #{req['Host']}" The host part of a URI for initialize seems to be the same thing of req['Host']. ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-27102 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-07-21 01:17
Issue #6482 has been updated by drbrain (Eric Hodel). File net.http.request_response_uri.3.patch added =begin naruse (Yui NARUSE) wrote: > drbrain (Eric Hodel) wrote: > > This does not seem to match the current behavior of req['Host'] as it must be manually cleared in order to reuse the request with a different host. > > Try following: > […] > > The host part of a URI for initialize seems to be the same thing of req['Host']. I think I don't understand. My patch uses the host part of URI for initialize to set req['Host']. Also, if you set req['Host'] the URI is updated correctly. Which server you connect to doesn't seem to matter. I don't see the request Host header matching the connection host address with current net/http: $ svnversion 36482 $ cat test.rb require 'net/http' req = Net::HTTP::Get.new '/' puts "req Host: #{req['Host']}" res = Net::HTTP.start 'redmine.ruby-lang.org' do |http| puts "con Host: #{http.address}" http.request req end puts "req Host: #{req['Host']}" res = Net::HTTP.start 'bugs.ruby-lang.org' do |http| puts "con Host: #{http.address}" http.request req end puts "req Host: #{req['Host']}" $ make runruby ./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems ./test.rb req Host: con Host: redmine.ruby-lang.org req Host: redmine.ruby-lang.org con Host: bugs.ruby-lang.org req Host: redmine.ruby-lang.org My latest patch has identical behavior: $ patch -p0 < net.http.request_response_uri.3.patch […] $ make runruby ./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems ./test.rb req Host: con Host: redmine.ruby-lang.org req Host: redmine.ruby-lang.org con Host: bugs.ruby-lang.org req Host: redmine.ruby-lang.org Identical test using URI instead of string path: $ cat test.rb require 'net/http' u = URI("http://redmine.ruby-lang.org/") req = Net::HTTP::Get.new u puts "req Host: #{req['Host']}" puts "req URI: #{req.uri}" res = Net::HTTP.start 'redmine.ruby-lang.org' do |http| puts "con Host: #{http.address}" http.request req end puts "req Host: #{req['Host']}" puts "req URI: #{req.uri}" res = Net::HTTP.start 'bugs.ruby-lang.org' do |http| puts "con Host: #{http.address}" http.request req end puts "req Host: #{req['Host']}" puts "req URI: #{req.uri}" $ make runruby ./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems ./test.rb req Host: redmine.ruby-lang.org req URI: http://redmine.ruby-lang.org/ con Host: redmine.ruby-lang.org req Host: redmine.ruby-lang.org req URI: http://redmine.ruby-lang.org/ con Host: bugs.ruby-lang.org req Host: redmine.ruby-lang.org req URI: http://redmine.ruby-lang.org/ =end ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-28241 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-08-27 14:01
Issue #6482 has been updated by naruse (Yui NARUSE). Let me summarize (because I forgot the detail)... An HTTP request has Host header. It is usually used for NameVirtualHost. Current net/http uses req['Host'] as Host header if explicitly set. If not set, the hostname used for TCP connection is set to req['Host'] and used. This topic is about initializing HTTPRequest with URI. The problem now discussing is the relation between the URI and Host header (req['Host']). 5.1.2 of RFC 2616 says > Host: www.w3.org Note that the "above" means http://www.w3.org/pub/WWW/TheProject.html So a URI for initialization overwrites requesting Host header. ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-29019 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-11-24 00:38
Issue #6482 has been updated by mame (Yusuke Endoh). Target version changed from 2.0.0 to next minor ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-33670 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: next minor =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-11-24 00:38
Issue #6482 has been updated by mame (Yusuke Endoh). Target version changed from next minor to 2.0.0 ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-33671 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-12-20 06:11
Issue #6482 has been updated by drbrain (Eric Hodel). File net.http.request_response_uri.4.patch added Ok, here is a patch that uses host from URI over connection host. ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-34884 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
on 2012-12-21 14:21
Issue #6482 has been updated by naruse (Yui NARUSE). drbrain (Eric Hodel) wrote: > Ok, here is a patch that uses host from URI over connection host. OK, commit it ---------------------------------------- Feature #6482: Add URI requested to Net::HTTP request and response objects https://bugs.ruby-lang.org/issues/6482#change-34947 Author: drbrain (Eric Hodel) Status: Assigned Priority: Normal Assignee: naruse (Yui NARUSE) Category: lib Target version: 2.0.0 =begin This patch adds the full URI requested to Net::HTTPRequest and Net::HTTPResponse. The goal of this is to make it easier to handle Location, Refresh, meta-headers, and URIs in retrieved documents. (While the HTTP RFC specifies the Location must be an absolute URI, not every server follows the RFC.) In order to process redirect responses from bad servers or relative URIs in requested documents the user must create an object that contains both the requested URI and the response object to create absolute URIs. This patch reduces the amount of boilerplate they are required to write. Only the (({request_uri})) is used from the URI given when creating a request. The URI is stored internally and updated with the host, port and scheme used to make the request at request time. The URI is then copied to the response object for use by the user. To preserve backwards compatibility the new behavior is optional. This allows requests with invalid URI paths like (({Net::HTTP::Get.new '/f%'})) to continue to work. Users of string paths will not be able to retrieve the requested URI. This patch is for support of #5064 =end
Enable email notification
Enable multi-page viewPlease log in before posting. Registration is free and takes only a minute.
Existing account
(Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
Log in with Google account | Log in with Yahoo account
No account? Register here.