Forum: Ruby-core [ruby-trunk - Feature #6421][Open] Add zlibwapi to extconf.rb file for zlib library

Issue #6421 has been reported by djberg96 (Daniel Berger).

----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421

Author: djberg96 (Daniel Berger)
Status: Open
Priority: Normal
Assignee:
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by luislavena (Luis Lavena).

Status changed from Open to Assigned
Assignee set to usa (Usaku NAKAMURA)

Hello,

According to the wiki, zlib has no maintainer:
http://bugs.ruby-lang.org/projects/ruby/wiki/Maintainers

Was my understanding that zlibwapi exported symbols as stdcall and not 
cdecl.

Assigning to Usaku Nakamura.


----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-26574

Author: djberg96 (Daniel Berger)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by usa (Usaku NAKAMURA).


Have anyone tested it?
If it has enough compatibility with normal zlib, there is no problem
I think.
----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-26578

Author: djberg96 (Daniel Berger)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by phasis68 (Heesob Park).


I have tested it.
The zlibwapi.dll can be stdcall or cdecl depend on the macro ZLIB_WINAPI 
defined or not.


I think there is no problem if it is not accepted.
You can rename zlibwapi.dll and zlibwapi.lib to zlib.dll and zlib.lib.

----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-26579

Author: djberg96 (Daniel Berger)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by luislavena (Luis Lavena).


phasis68 (Heesob Park) wrote:
> I have tested it.
> The zlibwapi.dll can be stdcall or cdecl depend on the macro ZLIB_WINAPI defined 
or not.
>

Just to be sure, Ruby zlib extension will need to ensure ZLIB_WINAPI is 
not defined (undef if necessary)

----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-26580

Author: djberg96 (Daniel Berger)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by usa (Usaku NAKAMURA).

Assignee changed from usa (Usaku NAKAMURA) to luislavena (Luis Lavena)

Sorry, I can't understand the conclusion.

(1) should apply the 1 line patch because it doesn't cause any problem.
(2) no need to apply the patch because the zlibwapi users should change 
the names of the dll and the lib.

Which?

Luis, you understand this ticket than me.
Please commit the patch or reject this ticket.

----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-32054

Author: djberg96 (Daniel Berger)
Status: Assigned
Priority: Normal
Assignee: luislavena (Luis Lavena)
Category: ext
Target version: 1.9.3


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan

Issue #6421 has been updated by luislavena (Luis Lavena).

Target version changed from 1.9.3 to 2.0.0

usa (Usaku NAKAMURA) wrote:
> Sorry, I can't understand the conclusion.
>
> Please commit the patch or reject this ticket.

Sorry for late response. I've committed this to trunk in r37527

Will open a backport request too.

Thank you
----------------------------------------
Feature #6421: Add zlibwapi to extconf.rb file for zlib library
https://bugs.ruby-lang.org/issues/6421#change-32512

Author: djberg96 (Daniel Berger)
Status: Closed
Priority: Normal
Assignee: luislavena (Luis Lavena)
Category: ext
Target version: 2.0.0


The vstudio contrib solution in zlib 1.2.7 creates a "zlibwapi" dll 
file. According to the readme.txt file, "The new DLL was renamed because 
there exist several incompatible versions of zlib.dll on the Internet."

So, I propose this very modest adjustment to the extconf.rb file for 
zlib:

-if %w'z libz zlib1 zlib zdll'.find {|z| have_library(z, 
'deflateReset')} and
+if %w'z libz zlib1 zlib zdll zlibwapi'.find {|z| have_library(z, 
'deflateReset')} and

Regards,

Dan