Forum: Ruby-Gnome 2 Fix for GLib::Spawn regression

Posted by Geoff Youngs (Guest)
on 2011-10-04 15:07
(Received via mailing list)
Hi,

I've just opened a pull request
https://github.com/ruby-gnome2/ruby-gnome2/pull/1 with a patch that
fixes GLib::Spawn.async, GLib::Spawn..async_with_pipes and
GLib::Spawn..sync when the environment parameter is nil.

I was hoping for someone else to check it over before I commit it -
I'm assuming I've understood the purpose of RVAL2STRV_ACCEPT_NIL, but
I could be wrong :)

Also I've added a test case, but I'm not sure whether it'll work on
Windows (or even how relevant it is there).

Thanks,


G.

--
Random Musing - http://www.frafferz.com/
Geek Blog - http://geoffyoungs.github.com/
Posted by Nikolai Weibull (Guest)
on 2011-10-04 15:22
(Received via mailing list)
On Tue, Oct 4, 2011 at 15:06, Geoff Youngs <g@intersect-uk.co.uk> wrote:

> Windows (or even how relevant it is there).
It’s correct and Kouhei has already committed it.

Thanks, and sorry about messing this up.
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.