Forum: IronRuby KCoding fix for Silverlight build (issue #5093)

Posted by Charles Strahan (charles-strahan)
on 2010-09-01 03:22
(Received via mailing list)
Here's my fix for a bug in the Silverlight build (issue
#5093<http://ironruby.codeplex.com/workitem/5093>
):
690730950522e4e65a0c<http://github.com/cstrahan/ironruby/commit/690730950522e4e65a0c069796dba2bb9300e60f>

-Charles
Posted by Tomas Matousek (Guest)
on 2010-09-01 03:29
(Received via mailing list)
KCodings are obsolete and should be completely removed. So I don't think 
this needs to be fixed.

Besides Encoding.UTF8 is not a UTF8 singleton. You can create multiple 
different UTF8Encoding instances. We should compare encoding CodePage 
but on Silverlight that property is not availabl, so we need to compare 
encoding name.

Tomas

From: ironruby-core-bounces@rubyforge.org 
[mailto:ironruby-core-bounces@rubyforge.org] On Behalf Of Charles 
Strahan
Sent: Tuesday, August 31, 2010 6:19 PM
To: ironruby-core@rubyforge.org
Subject: [Ironruby-core] KCoding fix for Silverlight build (issue #5093)

Here's my fix for a bug in the Silverlight build (issue 
#5093<http://ironruby.codeplex.com/workitem/5093>):
690730950522e4e65a0c<http://github.com/cstrahan/ironruby/commit/690730950522e4e65a0c069796dba2bb9300e60f>

-Charles
Posted by Charles Strahan (charles-strahan)
on 2010-09-01 10:01
(Received via mailing list)
>
> KCodings are obsolete and should be completely removed. So I don’t think
> this needs to be fixed.
>

Sweet - that works for me :).

Have you had a chance to take a look at my other commit (regarding issue
#4946)?

-Charles

On Tue, Aug 31, 2010 at 8:28 PM, Tomas Matousek <
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.