Forum: IronRuby Code Review: G19.Final

tfpt review "/shelveset:G19.Final;REDMOND\tomat"
  Comment  :
  Implements many 1.9 features and changes:
  -  Syntax - should now be fully compatible with 1.9.2.
  -  Semantics - many fixes, some features still not completed:
    o  Passing optional and block parameters to blocks
    o  Compound parameters unpacking, e.g. def foo((a, b), c); end
  -  Various small changes in libraries.

  Removes version command line switches (-1.9, -1.8). The only supported 
MRI version is 1.9 from now on. I've kept RubyCompatibility enum for 
now, but it should be removed along with all 1.8 specific features.
  Since we are still missing a lot of 1.9 features many failing tests 
and specs needs to be disabled for now (including Rails, Rubygems, and 
Rack).

Tomas

This change might break apps that already worked with IronRuby v1.0 or 
v1.1. The reason might be:
- IronRuby is now using 1.9.1 standard libraries, which might depend on 
1.9 features that are not yet implemented in IronRuby or are implemented 
incorrectly.
or
- the app uses 1.8 specific feature that is no longer supported in 1.9 
(might be a grammar change or change in runtime behavior).

If you need a stable IronRuby build that is compatible with 1.8.6 please 
use IronRuby v1.0 or v1.1 released in July. IronRuby v1.1 isn't as 
stable as v1.0 but is still compatible with 1.8.6.

And as usual, contributions are welcome. Should you find a missing 1.9 
feature don't hesitate, implement it and submit a patch!

Tomas

Nice work! Thanks Tomas

On Tue, Aug 17, 2010 at 1:42 PM, Tomas Matousek <

WOW! Did I read that right? It's "fully compatible with 1.9.2"? Tomas, 
thank
you. You are a machine.

Three cheers!

Ryan Riley


On Mon, Aug 16, 2010 at 6:16 PM, Tomas Matousek <

Don’t get too excited ☺, there is still a lot of work to be done in 
libraries and some in runtime to run all Ruby 1.9 apps.

Tomas

From: ironruby-core-bounces@rubyforge.org 
[mailto:ironruby-core-bounces@rubyforge.org] On Behalf Of Ryan Riley
Sent: Monday, August 16, 2010 8:52 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] Code Review: G19.Final

WOW! Did I read that right? It's "fully compatible with 1.9.2"? Tomas, 
thank you. You are a machine.

Three cheers!

Ryan Riley

On Mon, Aug 16, 2010 at 6:16 PM, Tomas Matousek 
<Tomas.Matousek@microsoft.com<mailto:Tomas.Matousek@microsoft.com>> 
wrote:
 tfpt review "/shelveset:G19.Final;REDMOND\tomat"
 Comment  :
 Implements many 1.9 features and changes:
 -     Syntax - should now be fully compatible with 1.9.2.
 -     Semantics - many fixes, some features still not completed:
         o     Passing optional and block parameters to blocks
         o     Compound parameters unpacking, e.g. def foo((a, b), c); 
end
 -     Various small changes in libraries.

 Removes version command line switches (-1.9, -1.8). The only supported 
MRI version is 1.9 from now on. I've kept RubyCompatibility enum for 
now, but it should be removed along with all 1.8 specific features.
 Since we are still missing a lot of 1.9 features many failing tests and 
specs needs to be disabled for now (including Rails, Rubygems, and 
Rack).

Tomas


_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org<mailto:Ironruby-core@rubyforge.org>
http://rubyforge.org/mailman/listinfo/ironruby-core

This is exciting news though, progress is good!

On Tue, Aug 17, 2010 at 12:07 AM, Tomas Matousek
<Tomas.Matousek@microsoft.com> wrote:
> [mailto:ironruby-core-bounces@rubyforge.org] On Behalf Of Ryan Riley
>
>  -     Syntax - should now be fully compatible with 1.9.2.
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core@rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>
>



--
Michael Letterle
IronRuby MVP
http://blog.prokrams.com

Awesome, Tomas!

I have no excuse now for not submitting some patches ;).

-Charles

On Mon, Aug 16, 2010 at 8:16 PM, Tomas Matousek <

I guess those changes have not made it to the git repository yet, right?
Anyway that's some great news, thanks again for all the awesome work!

On Tue, Aug 17, 2010 at 03:42, Tomas Matousek
<Tomas.Matousek@microsoft.com> wrote:
>
>  -     Syntax - should now be fully compatible with 1.9.2.
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core@rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>



--
Daniele Alessandri
http://clorophilla.net/
http://twitter.com/JoL1hAHN

They did.

http://github.com/ironruby/ironruby/commit/01a1d31f2dde357194c2f5caccdc8ead06033791

I forgot to attach a git comment to this shelveset, so unfortunately it 
just says "Sync to TFS changeset #".

Tomas

Thanks, actually it was just my local repository that (for some
reason) was still stuck to the commits pushed on date 2010-08-16.

On Thu, Aug 19, 2010 at 10:52, Tomas Matousek
<Tomas.Matousek@microsoft.com> wrote:
> Sent: Thursday, August 19, 2010 1:02 AM
>> - the app uses 1.8 specific feature that is no longer supported in 1.9 (might be a grammar change or change in runtime behavior).
>> To: IronRuby External Code Reviewers
>> end
>> http://rubyforge.org/mailman/listinfo/ironruby-core
> Ironruby-core@rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core@rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>



--
Daniele Alessandri
http://clorophilla.net/
http://twitter.com/JoL1hAHN