Forum: IronRuby Code Review: gems

Posted by Shri Borde (Guest)
on 2010-03-09 19:44
Attachment: gems.diff (3,68 KB)
(Received via mailing list)
tfpt review "/shelveset:gems;REDMOND\sborde"

  Comment  :
  When installing gems from a remote server that is using MRI, the gem 
information that is
   sent down to the local machine is incorrect since MRI is not able to 
parse the platform
   string of "universal-.net" until a patch is applied to RubyGems in 
Gem::Platform#initialize,
   similar to the way other platforms are handled in that method. 
IronRuby does include
   this patch. For now, we work around the problem in 
Gem::Specification._load

  Adds a case for "universal-.net" to Gem::Platform#=~. This may not be 
strictly needed to fix the problem above, but is included for 
completeness

  Running word_spec was leaving behind a Word dialog box asking whether 
to save the Word document or not. Fixed the spec to close Word without 
prompting.
Posted by Jim Deville (Guest)
on 2010-03-09 19:47
(Received via mailing list)
Looks good. We should probably make the same change in the Excel specs, 
but that isn't pressing.
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.