Forum: Ruby-core "rake not found" error on a rubygems test

Hi Eric Hodel,

Currently, a test of rubygems reports false error on my environment
that rake is not installed into PATH.
Could you commit the patch, or may I?


$ make test-all 
TESTS=test/rubygems/test_gem_commands_uninstall_command.rb
./miniruby -I./lib -I.ext/common -I./- -r./ext/purelib.rb
./tool/runruby.rb --extout=.ext  -- "./test/runner.rb"
test/rubygems/test_gem_commands_uninstall_command.rb
Loaded suite ./test/runner
Started
E..
Finished in 0.630337 seconds.

  1) Error:
test_execute_prerelease(TestGemCommandsUninstallCommand):
Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native
extension.

/home/mame/work/ruby/ruby mkrf_conf.rb

rake RUBYARCHDIR=/tmp/test_rubygems_13065/gemhome/gems/pre-2.b/lib
RUBYLIBDIR=/tmp/test_rubygems_13065/gemhome/gems/pre-2.b/lib
sh: rake: command not found


Gem files will remain installed in
/tmp/test_rubygems_13065/gemhome/gems/pre-2.b for inspection.
Results logged to
/tmp/test_rubygems_13065/gemhome/gems/pre-2.b/ext/a/gem_make.out

    /home/mame/work/ruby/test/rubygems/test_gem_commands_uninstall_command.rb:68:in
`block in test_execute_prerelease'
    /home/mame/work/ruby/test/rubygems/test_gem_commands_uninstall_command.rb:67:in
`test_execute_prerelease'

3 tests, 12 assertions, 0 failures, 1 errors, 0 skips
make: *** [yes-test-all] Error 1


diff --git a/test/rubygems/test_gem_commands_uninstall_command.rb
b/test/rubygems/test_gem_commands_uninstall_command.rb
index cd440f6..6113ed6 100644
--- a/test/rubygems/test_gem_commands_uninstall_command.rb
+++ b/test/rubygems/test_gem_commands_uninstall_command.rb
@@ -64,8 +64,10 @@ class TestGemCommandsUninstallCommand < 
GemInstallerTestCase

     util_setup_gem

-    use_ui @ui do
-      @installer.install
+    build_rake_in do
+      use_ui @ui do
+        @installer.install
+      end
     end

     @cmd.options[:args] = ["pre"]


Thanks,

Hi Eric Hodel,

Could you reply to this?


2010/3/9 Yusuke ENDOH <mame@tsg.ne.jp>:

Eric, you must reply to this ASAP!
Anyone who has a direct contact to Eric, please stimulate him.
I sent him a mail directly a week ago, but he does not reply.

If any reply does not come in three days, I'll suggest discharging him.
He is stopping many assigned tickets, including many "Urgent" ones.
I'm afraid if his unresponsiveness will hinder 1.9.2 release.

  2717  Bug  Assigned  Normal  Requiring rubygems/specification causes
tons of warnings for NoMethodError  Eric Hodel  2010/02/12 11:19 AM
  2689  Bug  Assigned  Normal  rdoc gem on 1.9.2 fails for
interactive(-i) ri  Eric Hodel  2010/02/04 02:09 AM
  2414  Bug  Assigned  Urgent  make test-all does not work after gem
update  Eric Hodel  2009/12/03 00:59 AM
  2355  Bug  Assigned  Urgent  Please update rubygems!  Eric Hodel
2009/12/03 14:06 PM
  2176  Bug  Assigned  Urgent  [rubygems] $LOAD_PATH includes bin
directory  Eric Hodel  2009/12/03 00:58 AM
  2066  Bug  Assigned  Normal  Merge Latest RDoc/Ri  Eric Hodel
2009/12/03 14:07 PM
  1948  Bug  Open  Low  RDoc Fails with Non-ASCII Pathnames  Eric
Hodel  2009/09/07 13:38 PM
  1421  Bug  Open  Low  Permission denied - ~/.ri  Eric Hodel
2009/07/23 09:58 AM
  1234  Bug  Open  Normal  RDoc failure in
benchmark/bm_so_meteor_contest.rb at or around line 542 column  Eric
Hodel  2009/07/23 09:39 AM
  1085  Bug  Assigned  Urgent  Got the error message, after run 'gem
install --test'.  Eric Hodel  2009/12/03 00:57 AM
  1040  Bug  Assigned  Urgent  rubygems/builder.rb should require
user_interaction  Eric Hodel  2009/12/03 00:57 AM
  843  Bug  Assigned  Urgent  RubyGems include useless libraries  Eric
Hodel  2009/12/03 00:57 AM
  825  Bug  Assigned  Urgent  Gem::Installer#generate_windows_script
$B$N0z?t$N=gHV$,B>$H0lCW$7$J$$(B  Eric Hodel  2009/12/03 00:56 AM
  549  Bug  Open  Normal  ri -f html mungles constants  Eric Hodel
2009/07/23 09:25 AM


2010/3/17 Yusuke ENDOH <mame@tsg.ne.jp>:

On Mar 16, 2010, at 08:35, Yusuke ENDOH wrote:

> Hi Eric Hodel,
> 
> Could you reply to this?



>> ./tool/runruby.rb --extout=.ext  -- "./test/runner.rb"
>> 
>> /tmp/test_rubygems_13065/gemhome/gems/pre-2.b/ext/a/gem_make.out
>> diff --git a/test/rubygems/test_gem_commands_uninstall_command.rb
>> +    build_rake_in do
>> +      use_ui @ui do
>> +        @installer.install
>> +      end
>>     end
>> 
>>     @cmd.options[:args] = ["pre"]

Sorry, I have been busy.

Please commit this patch to ruby, I have commited it to rubygems trunk.

On Mar 24, 2010, at 07:06, Yusuke ENDOH wrote:
Eric, you must reply to this ASAP!
> Anyone who has a direct contact to Eric, please stimulate him.
> I sent him a mail directly a week ago, but he does not reply.
> 
> If any reply does not come in three days, I'll suggest discharging him.
> He is stopping many assigned tickets, including many "Urgent" ones.
> I'm afraid if his unresponsiveness will hinder 1.9.2 release.

I have updated or closed as many tickets as I can.

I plan to import the latest RDoc on Sunday, Pacific Time which will 
allow me to close five of my tickets.  (I have lots of changes in it, so 
I'm running tests against all the gems to make sure it will work.)

I would like to make a new release of RubyGems to fix some outstanding 
issues, but I will need another week for backwards-compatibility testing 
on windows.

Is it acceptable to import RubyGems past the 1.9.2 freeze deadline? 
There are only bug fixes between 1.3.6 and RubyGems trunk.

Hi,

2010/3/26 Eric Hodel <drbrain@segment7.net>:
> On Mar 24, 2010, at 07:06, Yusuke ENDOH wrote:
> Eric, you must reply to this ASAP!
>> Anyone who has a direct contact to Eric, please stimulate him.
>> I sent him a mail directly a week ago, but he does not reply.
>>
>> If any reply does not come in three days, I'll suggest discharging him.
>> He is stopping many assigned tickets, including many "Urgent" ones.
>> I'm afraid if his unresponsiveness will hinder 1.9.2 release.
>
> I have updated or closed as many tickets as I can.

Thank you for your replying!  And forgive me for saying so rude.


> I plan to import the latest RDoc on Sunday, Pacific Time which will allow me to close five of my tickets. ?(I have lots of changes in it, so I'm running tests against all the gems to make sure it will work.)
>
> I would like to make a new release of RubyGems to fix some outstanding issues, but I will need another week for backwards-compatibility testing on windows.

What is done at 31 Mar. is just "freezing a spec".  You can import the
new release by 30 Apr. if the import is agreed (or preannounced by you
as the maintainer, at least) by 31 Mar.
Of course, ideally, it is better to explain in advance all new feature
that will be in the new release.

And, if the new release really has only bug fixes, you can commit it
even after 30 Apr.  Though, the release manager's consent is needed
before each commit.


So it would be better to prioritize checking "Feature" tracker tickets
currently:

- http://redmine.ruby-lang.org/issues/show/1800
- http://redmine.ruby-lang.org/issues/show/3010

Of course, urgent tickets should be checked soon, and if you think it is
not urgent, please change the priority to high or normal.


> Is it acceptable to import RubyGems past the 1.9.2 freeze deadline? ?There are only bug fixes between 1.3.6 and RubyGems trunk.

In conclusion, yes, it is acceptable without problem, I think.
Thank you for your consideration!