Code Review: Encs2 - Ruby Forum

Code Review: Encs2

Posted by Tomas Matousek (Guest)

on 2010-03-06 05:28

Attachment: Encs2.diff (103 KB)

tfpt review "/shelveset:Encs2;REDMOND\tomat"
  Comment  :

  Fixes bunch of encoding issues including 
http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3920.
  Fixes handling of DST transitions in Time operators.
  Fixes bug in Array: 
http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3314

Tomas

Edit | Move | Delete topic | Reply with quote

Re: Code Review: Encs2

Posted by Jim Deville (Guest)

on 2010-03-06 05:39

Please check newlines in the tags file, looks like 2 lines got joined.
Nice catch in each_char.rb

Rest looks good from hear.

JD

Edit | Delete | Reply with quote

Enable email notification |

Enable multi-page view

Please log in before posting. Registration is free and takes only a minute.

Existing account (Switch to SSL-encrypted connection)

NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account

No account? Register here.

User name or e-mail address
Password

Forum: IronRuby Code Review: Encs2